509427 - Minor test suite tweaks for themes (from blog)

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Admin/Editor Tools, defect)

Description

[Wil Clouser [:clouserw]]

Comment from the blog:

-------------------------------------------------------
Note that the verification suite generates lots of false hits on themes:
Things like:
chrome/littlefox.jar/browser/feedview.css (39) : Matched Pattern: “/-moz-binding:(?!\s*url\s*\(\s*["']?chrome:\/\/.*\/content\/)/”
and:
chrome.manifest (1) : Matched Pattern: “/^(?!(#|skin |style ))/”
are actually OK for themes.

So, the suite needs to be more tuned to Themes as well.

-------------------------------------------------------
We need to verify these tests and clarify if themes are different than extensions and adjust the tests accordingly.

Comment 1

[RJ Walsh [:rjwalsh]]

Attachment: Fix

Changes the remote javascript test to allow resources to be pulled from content or skin, as opposed to just content.
Changes the chrome manifest check to use the regex whitespace identifier as opposed to a space.  This will match both tabs and spaces.

Comment 2

[RJ Walsh [:rjwalsh]]

Fixed in r48920