509753 - Are our category total numbers broken?

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Wil Clouser [:clouserw]]

Attachment: s/tags/categories/

Have our category total numbers been broken since webmocha's stuff?

Comment 1

[Wil Clouser [:clouserw]]

production cron output confirms this is broken

Comment 2

[Jeff Balogh (:jbalogh)]

Comment on attachment 393823 [details] [diff] [review]
s/tags/categories/

Nice find.

Can you fix that HACK line while you're down there? `global $valid_status` works there.

Comment 3

[Jeff Balogh (:jbalogh)]

(In reply to comment #1)
> production cron output confirms this is broken

Where can I see that?

Comment 4

[Wil Clouser [:clouserw]]

(In reply to comment #3)
> (In reply to comment #1)
> > production cron output confirms this is broken
> 
> Where can I see that?

The amo-developers mailing list

Comment 5

[Wil Clouser [:clouserw]]

r48964 and r48965.  Not only did I fix the hack but that vim script kicked in and whacked all the trailing whitespace.

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

Oh, my; how do we verify this?

On https://preview.addons.mozilla.org/en-US/firefox/, Alerts & Updates now reads "587".  When I fire off a search in that category, it gives me "Showing 1 - 20 of 515 results" -- wherein lies the discrepancy?

Comment 7

[Wil Clouser [:clouserw]]

I just happen to have this picture from something else, so:

http://www.pict.com/view/1447409/0/addons2520for2520firefox

Those are the numbers I'm talking about.  On production AMO they haven't changed since we pushed tagging out.  (Same on preview, although they are updating now).

Comment 8

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED; https://addons.mozilla.org/en-US/firefox/ currently reads "655" for Alerts & Updates, and the screenshot in comment 7 reads 618.  I've checked; all numbers have pretty much gone up.