Closed
Bug 509886
Opened 15 years ago
Closed 15 years ago
Create nsChildView::GetCocoaWindow
Categories
(Core :: Widget: Cocoa, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.9.3a1
People
(Reporter: mstange, Assigned: mstange)
Details
Attachments
(1 file, 1 obsolete file)
|
5.68 KB,
patch
|
jaas
:
review+
|
Details | Diff | Splinter Review |
The code to get the view's nsCocoaWindow is duplicated three times, let's pull it out into a method.
Attachment #393980 -
Flags: review?(joshmoz)
Comment on attachment 393980 [details] [diff] [review] v1 The point of the delegate checking is to ensure that we get a XUL native window, not just any native window (from an embedder). This being the case, the new method is inappropriately named. It won't work in the embedding situation, it will return nsnull, and the name should reflect that. How about "GetXULNativeWindowWidget"?
|
Assignee | |
Comment 2•15 years ago
|
||
You're right, the current name is no good. I think I'd prefer GetXULWindowWidget (without the "Native"), because "native window" usually means "some Cocoa object, like NSWindow*". Do you agree?
|
|
Assignee | |
Comment 4•15 years ago
|
||
Same patch with new name.
Attachment #393980 -
Attachment is obsolete: true
Attachment #394212 -
Flags: review?(joshmoz)
Attachment #393980 -
Flags: review?(joshmoz)
Attachment #394212 -
Flags: review?(joshmoz) → review+
|
|
Assignee | |
Comment 5•15 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/6b30334ec120
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•15 years ago
|
Target Milestone: --- → mozilla1.9.3
|
||
Updated•15 years ago
|
Target Milestone: mozilla1.9.3 → mozilla1.9.3a1
You need to log in
before you can comment on or make changes to this bug.
Description
•