509954 - Make F5 reload on other platforms than Windows

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect)

Description

[Robert Kaiser]

[Hrm, we don't have a Bugzilla component for browser window issues. Too bad.]

I'm not sure where it was, but I saw people surprised that F5 didn't reload on Linux SeaMonkey, as most Linux desktop apps nowadays have adopted that keybinding.

Looking at http://mxr.mozilla.org/comm-central/source/mozilla/browser/base/content/browser-sets.inc#263 I see that Firefox enables it on all platforms, only accel-F5 is non-Mac-only for the browser while http://mxr.mozilla.org/comm-central/source/mozilla/toolkit/components/viewsource/content/viewSource.xul#123 shows that view source has both defined for everyone - Stefan, do you know the reason for the exception?

I think we should go and move our definitions from http://mxr.mozilla.org/comm-central/source/suite/browser/win/platformNavigationBindings.xul#16 to a general place to follow suit(e) and also expectations users seem to have nowadays.

Comment 1

[Robert Kaiser]

As a side note, bug 79397 and bug 129823 are competing for the same key in mailnews ;-)

Comment 2

[Stefan [:stefanh]]

Accel+F5 on mac enables Voice Over (bug 307061). I think the viewsource part was just missed (bug 230693).

Comment 3

[Jens Hatlak (:InvisibleSmiley)]

I think we should really have this. Just checked Firefox 3.5, Minefield, Konqueror, Opera, and Chromium, all on Kubuntu. All support F5 = Reload.

Firefox has F5 on all platforms, and Shift+F5 on all but Mac (cf. browser-sets.inc). To achieve the same, we have two options:
a) do it like FF, i.e. add it to navigatorOverlay.xul, preprocess that file (currently it isn't, cf. jar.mn) and use an #ifndef XP_MACOSX rule there
b) add it to the individual platform files that don't have it yet (mac/, unix/), leaving out Accel+F5 for Mac.

Neil, feel free to un-CC yourself but please answer the above question first.

Comment 4

[Stefan [:stefanh]]

Firefox having F5 on Mac is probably a mistake that no-one has discovered yet, no need to repeat that. We have Accel+R in the menu and that should be enough.

I can btw probably answer for Neil - b) is the way to go, we already have the files for doing this, so there's no need to pre-process ;-)

Comment 5

[Jens Hatlak (:InvisibleSmiley)]

Attachment: make F5 Reload [Checkin: comment 6]

So, after Stefan's feedback, let's only add Unix support (Win already has it, from where I copied it). No changes made to the shortcuts file since no entry exists there for Windows either and it's only a secondary shortcut which doesn't appear in the menu.

Comment 6

[Jens Hatlak (:InvisibleSmiley)]

Comment on attachment 487740 [details] [diff] [review]
make F5 Reload [Checkin: comment 6]

http://hg.mozilla.org/comm-central/rev/656d8167f3a2

Comment 7

[Robert Kaiser]

(In reply to comment #4)
> Firefox having F5 on Mac is probably a mistake that no-one has discovered yet

Could you please file it there, then? Thanks!