Closed Bug 510798 Opened 15 years ago Closed 15 years ago

Omit "--- Comment 0" line for new bugs

Categories

(Bugzilla :: Email Notifications, defect)

Product:
Bugzilla
Component:
Email Notifications
Version:
3.4.1
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Bugzilla 3.4

People

(Reporter: fpeters, Assigned: LpSolit)

References

Details

(Keywords: regression)

Attachments

(1 file)

patch, v1
786 bytes, patch
mkanat
: review+
Details | Diff | Splinter Review 
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en; rv:1.9.0.12) Gecko/20080528 Epiphany/2.22 (Debian/2.26.3-1)
Build Identifier: 

The bugmails for submitted bugs include a comment header:
  --- Comment #0 from Frederic Peters <fpeters@0d.be> 2009-08-16 18:11:06 UTC ---

In the old GNOME bugzilla install those didn't exist.


Reproducible: Always
Note this doesn't happen on this bugzilla installation (3.2.4).

FWIW the issue was initially reported, with a patch, as http://bugzilla.gnome.org/show_bug.cgi?id=591999
Looks like this was introduced with bug 457657
Yes, looks like we remove the |if $count| check in bug 457657.
Severity: enhancement → minor
Status: UNCONFIRMED → NEW
Depends on: 457657
Ever confirmed: true
Keywords: regression
OS: Linux → All
Hardware: x86 → All
Target Milestone: --- → Bugzilla 3.4
Version: unspecified → 3.4.1
Attached patch patch, v1 — — Splinter Review 
The right patch in the right bug...
Assignee: email-notifications → LpSolit
Status: NEW → ASSIGNED
Attachment #396016 - Flags: review?(mkanat)
Attachment #396016 - Flags: review?(mkanat) → review+
Flags: approval3.4+
Flags: approval+
tip:

Checking in template/en/default/email/newchangedmail.txt.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/email/newchangedmail.txt.tmpl,v  <--  newchangedmail.txt.tmpl
new revision: 1.15; previous revision: 1.14
done

3.4.1:

Checking in template/en/default/email/newchangedmail.txt.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/email/newchangedmail.txt.tmpl,v  <--  newchangedmail.txt.tmpl
new revision: 1.12.2.3; previous revision: 1.12.2.2
done
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: