511116 - Firefox tree should be default on dashboard, not Firefox3.5

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Johnathan Nightingale [:johnath]]

Attachment: Change the DEFAULT_TREE variable

The firefox3.5 default was a product of the release climate in which the dashboard was written.  Long term, it should default to trunk.

Comment 1

[John O'Duinn [:joduinn] (please use "needinfo?" flag)]

Johnath:

1) By dashboard, I assume you mean tinderboxpushlog dashboard? (just to be sure)

2) catlee is on leave for a while; if you are looking for a timely review, maybe reassign to someone else who understands tinderboxpushlog?

Comment 2

[Johnathan Nightingale [:johnath]]

Hey John - I mean the perf dashboard (see URL), not tbpl. I'd be happy to tag someone else for review - honestly I don't think it needs review, it's a one-liner change to a constant built for this purpose in code that I wrote.  :) But even if I pushed it, someone else would have to tell graph server to re-pull from hg.

On the plus side, there's no particular need for it to happen in a timely way. But if you can suggest an alternate, I'd welcome that too!

Comment 3

[[e-mail] (:bhearsum)]

Comment on attachment 395054 [details] [diff] [review]
Change the DEFAULT_TREE variable

I'll land this in a bit.

Comment 4

[[e-mail] (:bhearsum)]

Comment on attachment 395054 [details] [diff] [review]
Change the DEFAULT_TREE variable

changeset:   239:bc42a5fd4013

I'm pretty sure the dashboard will pick this up automatically.

Comment 5

[[e-mail] (:bhearsum)]

graph server has been updated now.

Comment 6

[Nick Thomas [:nthomas] (UTC+12)]

So for future reference, the way to deploy the change was to commit to repo at http://hg.mozilla.org/graphs/ and then go to cruncher:/home/catlee/graphs and pull in the change ? And that will update cruncher:/var/www/html/dashboard next time it runs, and graphs.m.o will rsync that in ?

Comment 7

[[e-mail] (:bhearsum)]

(In reply to comment #6)
> So for future reference, the way to deploy the change was to commit to repo at
> http://hg.mozilla.org/graphs/ and then go to cruncher:/home/catlee/graphs and
> pull in the change ? And that will update cruncher:/var/www/html/dashboard next
> time it runs, and graphs.m.o will rsync that in ?

I don't know what the intended method is, here's what I did:
* Landed change
* Updated cruncher:/home/catlee/graphs
* Manually edited cruncher:/var/www/html/dashboard/dashboard.js
* Waited 5 minutes for graphs.m.o to pick it up

/var/www/html/dashboard isn't a clone of anything so I don't know what the intended process here is supposed to be. I manually edited it with only the change I wanted to make sure we didn't pull in anything unexpected.

Comment 8

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/9a9c1c66e658fbbd4218937f8ba8c737cb08b586
bug 511116: Firefox tree should be default on dashboard, not Firefox3.5. r=me, patch=johnath

--HG--
branch : 1.0