511527 - Escape characters showing up in Twitter when sharing add-on/collections

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

STR:

1. Load https://preview.addons.mozilla.org/en-US/firefox/addon/8585
2. Click the "Share this Add-on" link, and choose Twitter (also shows up onhttps://preview.addons.mozilla.org/en-US/firefox/collection/webdeveloper for collections)
3. Look at the output

Expected Results:

stephend's 3000!!! 2.0 :: Add-ons for Firefox https://preview.addons.mozilla.org/en-US/firefox/addon/8585

Actual Results:

stephend's 3000!!! 2.0 :: Add-ons for Firefox https://preview.addons.mozilla.org/en-US/firefox/addon/8585

Comment 1

[Wil Clouser [:clouserw]]

This will also affect collection's "share this" links.

Comment 2

[u278084]

Attachment: v1

Simple fix. html_entity_decode doesn't decode single quotes by default.

Comment 3

[Fred Wenzel [:wenzel]]

Comment on attachment 397536 [details] [diff] [review]
v1

Thanks!

Comment 4

[u278084]

In r53010. Sorry. I am super lame for not checking this in earlier.

Comment 5

[u278084]

Sorry for bugspam. Also in r53012 because only half the patch was in my repo for some strange reason.

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Post-fix screenshot

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED; thanks, Cesar!