511584 - Update libfishsound

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

Update libfishsound to upstream current git HEAD.

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Patch

Update libfishsound to 20609d34c41fa.

Comment 2

[Chris Pearce [:cpearce (Not reading bugmail)]]

Pushed to m-c: http://hg.mozilla.org/mozilla-central/rev/2db5b995c28f

Comment 3

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 397087 [details] [diff] [review]
Patch 

This is supposed to be required by bug 512328, its the upstream commit logs say that they require the this fishsound update. Bug 512328 landed on 1.9.2, but I forgot to land this one, so we should land this on 1.9.2 as well.

Comment 4

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 397087 [details] [diff] [review]
Patch 

Requesting approval for this on 1.9.1 as well.
We should have this patch everywhere we have the patch for bug 512328, which people want on 1.9.1. So we need this on 1.9.1 as well.

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 397087 [details] [diff] [review]
Patch 

a192=beltzner

Comment 6

[Daniel Veditz [:dveditz]]

Comment on attachment 397087 [details] [diff] [review]
Patch 

Approved for 1.9.1.4, a=dveditz

Comment 7

[Chris Pearce [:cpearce (Not reading bugmail)]]

Pushed to 1.9.2: http://hg.mozilla.org/releases/mozilla-1.9.2/rev/4e626ba52d2a

Comment 8

[Chris Pearce [:cpearce (Not reading bugmail)]]

Pushed to 1.9.1: http://hg.mozilla.org/releases/mozilla-1.9.1/rev/a8572eafe369

Comment 9

[Tony Chung [:tchung]]

cpearce, how can QA test libfishsound?  can you provide some front end testcases on what to expect?   Thanks.

Comment 10

[cajbir (:cajbir)]

Play any Ogg file with sound. If file plays and the sound is audible, libfishsound is working.

Comment 11

[Al Billings [:abillings - ex-MoCo]]

Verified for 1.9.1 with wonderful ogg music at http://commons.wikimedia.org/wiki/File:12-04-2005-2400.ogg with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.1.4pre) Gecko/20090930 Shiretoko/3.5.4pre.