511898 - Double-click with two clicks on different areas of the page results in zoom of area of second click

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Panning/Zooming, defect)

Description

[Aakash Desai [:aakashd]]

Build Id:

Mozilla/5.0 (X11; U; Linux armv6l; en-US; rv:1.9.3a1pre) Gecko/20090821
Fennec/1.0b3pre

and

Mozilla/5.0 (Macintosh; U; Intel Mac OSX 10.5; en-US; rv:1.9.2a2pre)
Gecko/20090808 Fennec/1.0b3pre

Steps to Reproduce:
1. Reproduce a zoom by double clicking with a single click on two separate parts of the page really quickly.

Actual Results:
The double-click zooms in where the second click occurred.

Expected Results:
The double-click should only zoom when the clicks have occurred within a smaller/distinct area of pixels.

Comment 1

[Ben Combee (:bcombee)]

We could reuse the click radius to determine if the two-parts of the double click are sufficiently close.

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

If we don't dispatch the double click are we supposed to dispatch 2 single click?
I fear this can possibly results into click that are not really wanted?

Comment 3

[Ben Combee (:bcombee)]

Comment on attachment 401803 [details] [diff] [review]
Patch

I don't like doing two single clicks, especially if one causes a content change.  I'd prefer to just eat both events here, as this is likely a glitch and not what the user wanted.

Comment 4

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch v0.2

* don't dispatch the click if they were too far
* Zoom in the area of the _first_ click if dblClick is in the good radius


The patch needs to be test a bit more on device though.

Comment 5

[Ben Combee (:bcombee)]

Comment on attachment 403215 [details] [diff] [review]
Patch v0.2

Code works for me

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

Works for me too

pushed:
https://hg.mozilla.org/mobile-browser/rev/42151c6f6349

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

hg qref fail!

real push:
https://hg.mozilla.org/mobile-browser/rev/429b0e7640f3

Comment 8

[Aakash Desai [:aakashd]]

verified FIXED on builds:

Mozilla/5.0 (X11; U; Linux armv7l; en-US; rv:1.9.2b1pre) Gecko/20091026
Fennec/1.0b5pre

and

Mozilla/5.0 (X11; U; Linux armv6l; en-US; rv:1.9.3a1pre) Gecko/20091026
Fennec/1.0b5pre


There's a new bug or two that came out of this, but this is definitely nice to have :).

Comment 9

[Aakash Desai [:aakashd]]

litmus test case 9794 has been created for regression testing this bug.