512055 - Prism Text Search goes backwards (Next/F3 goes up instead of down through the document)

Status: RESOLVED FIXED

(Mozilla Labs :: Prism, defect)

Description

[miahz]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1.2) Gecko/20090729 Firefox/3.5.2
Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1.2) Gecko/20090729 Firefox/3.5.2 Prism/1.0b2

Text searching cycles backwards through the matches on the page.  Hit F3 or the Next button in the text search bar, and it jumps to the previous match, not the next.

Reproducible: Always

Steps to Reproduce:
1. Start typing or hit Ctrl/Cmd-F and type something
2. Hit F3 or click the Next button

Actual Results:  
The Previous text match is highlighted instead of the Next

Comment 1

[paulv]

This is because the arguments to onFindAgainCommand are backwards in webrunner.js. I applied the following patch and rebuilt and everything seems to work correctly.

Comment 2

[paulv]

Attachment: Patch to fix prism search

Comment 3

[Matthew Gertner]

Thanks for this. Please flag me for review and I'll get this checked in.

Comment 4

[Matthew Gertner]

Sending        chrome/content/webrunner.js
Transmitting file data .
Committed revision 64705.