512454 - Improve the look of the inline attachment separator.

Status: RESOLVED FIXED

(SeaMonkey :: Themes, enhancement)

Description

[Blake Winton (:bwinton) (:☕️)]

Attachment: A patch for theme changes to SeaMonkey.

In bug 509616 I made some changes to Thunderbird to make the attachment separator prettier, but I couldn't get a working build of SeaMonkey to test similar changes to it, so I left them out of that patch.

Anyways, here are the theme changes, still untested, and a fix for a nit that Neil found after it was checked in.

Thanks,
Blake.

Comment 1

[[e-mail]]

Comment on attachment 396426 [details] [diff] [review]
A patch for theme changes to SeaMonkey.

(Applies to both themes)
>+.mimeAttachmentHeader {
>+  width: 98%;
Because of the way widths are calculated, this is actually relative to the window width, not the automatic width (which is 20px less). This means that if your window is 1000 pixels wide then the size works out to be the same and if your window is narrow then this actually makes the fieldset wider!

I guess you have three options:
1. Make the width less. 97% is borderline, 96% would be better, or even less.

2. Don't set the width; just use the defaults.

3. As 2. but also set an end margin, e.g. use -moz-margin-end: 2%;
(You may also want to set a start margin, to override the default 2px.)

Comment 2

[Blake Winton (:bwinton) (:☕️)]

Attachment: The previous patch, with Neil's and Andreas's suggestions [Checkin: Comment 4]

Comment 3

[Andreas Nilsson (:andreasn)]

Comment on attachment 396443 [details] [diff] [review]
The previous patch, with Neil's and Andreas's suggestions
[Checkin: Comment 4]

Tested on Linux, OS X and Vista. Looks good!

Comment 4

[Serge Gautherie (:sgautherie)]

Comment on attachment 396443 [details] [diff] [review]
The previous patch, with Neil's and Andreas's suggestions
[Checkin: Comment 4]


http://hg.mozilla.org/comm-central/rev/a39d775470fc