512457 - Report errors before they get eaten up by runInBatchMode

Status: RESOLVED FIXED

(Firefox :: Sync, defect, P2)

Description

[misc-publicinbox]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US) AppleWebKit/532.0 (KHTML, like Gecko) Chrome/4.0.202.0 Safari/532.0
Build Identifier: 0.6pre3

When attempting to sync to the Weave server, it fails and returns the error below: 

009-08-25 09:08:58	FaultTolerance       DEBUG	Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsINavHistoryService.runInBatchMode] Stack trace: HistoryEngine__sync()@history.js:68 < WrappedNotify()@util.js:115 < Engine_sync()@engines.js:186 < WeaveSvc__syncEngine()@service.js:1236 < anonymous()@service.js:1208 < WrappedNotify()@util.js:115 < WrappedLock()@util.js:87 < WrappedCatch()@util.js:66 < WeaveSvc_sync()@service.js:1130 < WeaveSvc__observe()@service.js:458



Reproducible: Always

Steps to Reproduce:
1. Login to Weave
2. Sync.
3.
Actual Results:  
009-08-25 09:08:58	FaultTolerance       DEBUG	Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsINavHistoryService.runInBatchMode] Stack trace: HistoryEngine__sync()@history.js:68 < WrappedNotify()@util.js:115 < Engine_sync()@engines.js:186 < WeaveSvc__syncEngine()@service.js:1236 < anonymous()@service.js:1208 < WrappedNotify()@util.js:115 < WrappedLock()@util.js:87 < WrappedCatch()@util.js:66 < WeaveSvc_sync()@service.js:1130 < WeaveSvc__observe()@service.js:458

Expected Results:  
Sync successfully.

This started happening on the morning of 8/24. It has continued until today. I've tried to do this with FF 3.5.2 & 0.6pre3 on Vista, XP, and Ubuntu machines.

Comment 1

[Ed Lee :Mardak]

We should wrap runInBatchMode with a catch to report errors correctly. Right now we don't know what's going on here.

Did you see errors with any other engines? unwrapSymmetrickey?

Comment 2

[misc-publicinbox]

Not sure what caused the issue, but deleting my server data fixed it. There's some speculation over on the Weave discussion group that a server change might have caused it. This bug can probably be closed now.

Comment 3

[Ed Lee :Mardak]

http://hg.mozilla.org/labs/weave/rev/3acd6086d19f
Save the exception from inside runBatched and not have runInBatchMode return failure, so we can then expose the exception.