512558 - Tweak templates to improve accessibility

Status: RESOLVED INVALID

(support.mozilla.org :: Knowledge Base Software, task)

Description

[James Socol [:jsocol, :james]]

The two easy things I noticed are:

1) Breadcrumbs in the Knowledge Base have a title attribute on the KB link that will make it read as "browse category". It should either be removed or replaced with "Browse the Knowledge Base" (I vote for remove).

2) A few form fields use <input>label</input> (which is invalid anyway) instead of <label><input/> label</label>. This only seems appear in the poll area, but it couldn't hurt to quick check form labels in general.

Comment 1

[Paul Craciunoiu [:paulc]]

(In reply to comment #0)
> 1)
I vote for remove as well. In general, I find title hints annoying and useless (as a user that needs instant gratification :D). Either that or we add cool "hints" with javascript ;)
> 
> 2) A few form fields use <input>label</input> (which is invalid anyway) instead
> of <label><input/> label</label>. This only seems appear in the poll area, but
> it couldn't hurt to quick check form labels in general.
AFAIK, you don't need to embed inputs in labels, you can use the "for" attribute. Can labels (which do not display as blocks) validly embed inputs?

Comment 2

[James Socol [:jsocol, :james]]

(In reply to comment #1)
> I vote for remove as well. In general, I find title hints annoying and useless
> (as a user that needs instant gratification :D). Either that or we add cool
> "hints" with javascript ;)

There's no real need for hints. The link text itself is very descriptive. From an a11y standpoint, the title is generic and meaningless (ie: "What category?"); from a non-a11y standpoint, it's pretty useless (who hovers over the KB link in the breadcrumb wondering where it goes?).

> AFAIK, you don't need to embed inputs in labels, you can use the "for"
> attribute. Can labels (which do not display as blocks) validly embed inputs?

Both options, implicit and explicit--with "for"--are valid. The "for" attribute exists specifically for cases where it's impractical or impossible to wrap the <input> element with a <label>.

FWIW, since both <input> and <label> are inline, there is no problem putting <input> inside <label>.

Comment 3

[Chris Ilias [:cilias]]

(In reply to comment #0)
> The two easy things I noticed are:
> 
> 1) Breadcrumbs in the Knowledge Base have a title attribute on the KB link that
> will make it read as "browse category". It should either be removed or replaced
> with "Browse the Knowledge Base" (I vote for remove).

FWIW, either way is fine with me.

Comment 4

[Kadir Topal [:atopal]]

We currently don't have breadcrumbs to browse the KB.