512651 - lessen the write access checks during startup and remove final-ui-startup observer

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect, P2)

Description

[Robert Strong (they/them - no direct email)]

I believe this was initially coded this way for simplicity and this can at the very least be improved.

Comment 1

[Robert Strong (they/them - no direct email)]

Note: this may need to leverage bug 512650

Comment 2

[Robert Strong (they/them - no direct email)]

Attachment: patch in progress rev1

Comment 3

[Robert Strong (they/them - no direct email)]

Bug 512994 removes one of the deletions so adding dependency

Comment 4

[Robert Strong (they/them - no direct email)]

Attachment: patch in progress rev2

Comment 5

[Robert Strong (they/them - no direct email)]

Bug 512994 makes it so we don't delete / recreate the updates/0 directory on startup so updating summary.

Comment 6

[Robert Strong (they/them - no direct email)]

Attachment: patch in progress rev3

Comment 7

[Robert Strong (they/them - no direct email)]

Attachment: patch in progress rev4

Comment 8

[Robert Strong (they/them - no direct email)]

I'm going to remove the workaround for bug 497578 which is fixed by bug 496335 so adding dependency.

Comment 9

[Robert Strong (they/them - no direct email)]

Attachment: patch rev1

Comment 10

[Robert Strong (they/them - no direct email)]

Dave, I just noticed that the following is not used so I'd like to remove it at the same time as I check this in
/**
 * Gets a File URL spec for a nsIFile
 * @param   file
 *          The file to get a file URL spec to
 * @returns The file URL spec to the file
 */
function getURLSpecFromFile(file) {
  var ioServ = Cc["@mozilla.org/network/io-service;1"].
               getService(Ci.nsIIOService);
  var fph = ioServ.getProtocolHandler("file").
            QueryInterface(Ci.nsIFileProtocolHandler);
  return fph.getURLSpecFromFile(file);
}

Comment 11

[Robert Strong (they/them - no direct email)]

Per bug 311965 comment #42 it looks like this will reduce nsUpdateService.js TS by about 70ms on Maemo.

from 10/8 with this patch and the patch from Bug 520526 applied
nsUpdateService.js : 78+2+7+2+30    = 119

from 10/2
nsUpdateService.js : 138+2+6+9+33   = 188ms

from 7/21
nsUpdateService.js : 109+2+28+36+25 = 200ms

Comment 12

[Robert Strong (they/them - no direct email)]

Attachment: patch as checked in

Comment 13

[Robert Strong (they/them - no direct email)]

Pushed to mozilla-central
http://hg.mozilla.org/mozilla-central/rev/64e1e88b4d77

Comment 14

[Robert Strong (they/them - no direct email)]

Drivers, according to Taras' logs this reduces TS on Maemo from somewhere between 45ms and 65ms so requesting blocking.

Comment 15

[Robert Strong (they/them - no direct email)]

Comment on attachment 405559 [details] [diff] [review]
patch as checked in

Drivers, this has baked for a while now and improves TS at least on Fennec and possibly around .5% on desktop.

Comment 16

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 405559 [details] [diff] [review]
patch as checked in

a191=beltzner

Comment 17

[Mike Beltzner [:beltzner, not reading bugmail]]

er, a192

Comment 18

[Robert Strong (they/them - no direct email)]

Pushed to mozilla-1.9.2 - forgot to add the a=beltzner in the comment :(
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/b9c0c7338779