512728 - Fast startup should allow restarts and cope with non "-faststart" starts

Status: VERIFIED FIXED

(Toolkit Graveyard :: XULRunner, defect)

Description

[Brian Crowder]

+++ This bug was initially created as a clone of Bug #512330 +++

The faststartup component does need to listen to quit-application-requested and exitLastWindowClosingSurvivalArea() so that the app can shutdown/restart.  Also, if the faststart component is installed, we assume you always want the faststart behavior.  "-faststart" only means that you don't wish to open the default window on startup, now.  This means that when you close that window, the "daemon" will continue running.

Comment 1

[Brian Crowder]

Attachment: better handling of restarts

Comment 2

[Brian Crowder]

Attachment: less dumps

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 396759 [details] [diff] [review]
less dumps

>diff --git a/toolkit/components/faststart/FastStartup.js b/toolkit/components/faststart/FastStartup.js

>-  this.QueryInterface = XPCOMUtils.generateQI([Ci.nsIObserver]);
>+  this.QueryInterface = XPCOMUtils.generateQI([Ci.nsIObserver, Ci.nsISupportsWeakReference]);

I guess we're relying on nsWindowWatcher::RegisterNotification passing "false"
for aOwnsWeak on its AddObserver calls, here, to avoid being GCed. That was
true before, but with this change it's theoretically possible for that to turn
into a weak ref if someone ends up changing that method in the future. Granted
that's unlikely, but perhaps it would be worth a comment?

"-faststart" is a bit of a misleading parameter name, I think, especially given its new meaning. Can we change it to something clearer? "-hide", maybe?

Comment 4

[Brian Crowder]

Attachment: with comment and -faststart changed to -faststart-hidden

Carrying over gavin's r+.  This is what I will land.

Comment 5

[Brian Crowder]

Attachment: granted, not requested

exitBlahBlahSurvivalArea() in quit-app-requested is erroneous, it must happen in quit-app-granted.

Comment 6

[Brian Crowder]

http://hg.mozilla.org/mozilla-central/rev/3a3f9a03e210

Comment 7

[Joel Maher ( :jmaher ) (UTC -8)]

verfied with 20090827 nightly trunk build of fennec.  As a note, the startup time after the addon triggered reboot is much longer, but it does restart.  It also has the splashscreen during that restart.  Future restarts are fast and as expected.

Great work!

Comment 8

[Brian Crowder]

Comment on attachment 396794 [details] [diff] [review]
granted, not requested

This has already landed in 192, sorry for missing clearing the flag.