512809 - signup form uses colors for input validation feedback

Status: VERIFIED FIXED

(Firefox :: Sync, defect, P1)

Description

[Dan Mills [:thunder]]

It was a quick hack, and needs to be replaced with something more accessible.  Not everyone can see red/green.

Comment 1

[Dan Mills [:thunder]]

Attachment: Use text (in addition to colors)

Patch also includes some extra unrelated stuff to implement the start over bubble.

Comment 2

[Dan Mills [:thunder]]

I should also note that the patch doesn't fix all of the problems we currently have with error reporting in about:weave, or all the instances where we use colors in fields.  But it's a definite improvement over what we currently do.

Comment 3

[Ed Lee :Mardak]

http://hg.mozilla.org/labs/weave/rev/2849b32ac6b5
Add initial error reporting and "available" tagging. Also add "start over" functionality and change some custom settings display.

Comment 4

[Ed Lee :Mardak]

Comment on attachment 402778 [details] [diff] [review]
Use text (in addition to colors)

http://hg.mozilla.org/labs/weave/rev/40eb7be53737
Wire up "custom" inputs to set/read and show/hide server url box.

Comment 5

[Ed Lee :Mardak]

http://hg.mozilla.org/labs/weave/rev/fef981c73dd5
Reload the page instead of ending up with nothing when clicking "cancel" from start over.

Comment 6

[Ed Lee :Mardak]

http://hg.mozilla.org/labs/weave/rev/31f470639028
Add some account creation error handling, but it's still pretty clunky with username detection and alerts for other stuff.

Comment 7

[Tony Chung [:tchung]]

Verified fix on weave 1.3b5.