513108 - Enforce uniqueness for all models

Status: RESOLVED FIXED

(Webtools Graveyard :: Cesium, defect)

Description

[Ryan Doherty (:rdoherty)]

Doesn't appear that our constraints for username, site url and page are being enforced.

Comment 1

[Jeff Balogh (:jbalogh)]

I don't see any constraints in the models.  What is it supposed to be?

Comment 2

[Ryan Doherty (:rdoherty)]

This was enforced with Sites.for_user, so we're good.

Comment 3

[Ryan Doherty (:rdoherty)]

f, no this wasn't.

Requirements:
-Username must be unique
-Site base url should be unique
-Page url + site_id should be unique

Comment 5

[Jeff Balogh (:jbalogh)]

Attachment: adding unique constraint for (page.url, page.site_id)

Comment 6

[Ryan Doherty (:rdoherty)]

Comment on attachment 401598 [details] [diff] [review]
adding unique constraint for (page.url, page.site_id)

We need uniqueness in the db, but when a user adds a site and pages to track, we shouldn't show any errors if the site and pages exist already.

Currently errors are displayed when adding a site that already exists ("Site with this Base url already exists.")

Comment 7

[Jeff Balogh (:jbalogh)]

(In reply to comment #6)
> Currently errors are displayed when adding a site that already exists ("Site
> with this Base url already exists.")

I think that would be a different bug like "use page.get_or_create to make newish Pages".

Comment 8

[Ryan Doherty (:rdoherty)]

(In reply to comment #7)
> (In reply to comment #6)
> > Currently errors are displayed when adding a site that already exists ("Site
> > with this Base url already exists.")
> 
> I think that would be a different bug like "use page.get_or_create to make
> newish Pages".

wfm if you create the bug :)

Comment 9

[Jeff Balogh (:jbalogh)]

r52069