513208 - Tracemonkey build failed on solairs at jsnum.h.

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Leon Sha]

This bug happened after the fix for bug 513063 commited.
"jsnum.h", line 98: Error: The function "finite" must have a prototype.
"jsnum.h", line 109: Error: The function "isinf" must have a prototype.
"jsnum.h", line 119: Error: The function "signbit" must have a prototype.
"jsnum.h", line 141: Error: The function "signbit" must have a prototype.

Comment 1

[Leon Sha]

Attachment: patch

Comment 2

[Andreas Gal :gal]

Comment on attachment 397237 [details] [diff] [review]
patch

Thanks Leon!

Comment 3

[Jeff Walden [:Waldo]]

Comment on attachment 397237 [details] [diff] [review]
patch

>diff --git a/js/src/jsnum.h b/js/src/jsnum.h

> static inline int
> JSDOUBLE_IS_NEGZERO(jsdouble d)
> {
> #ifdef WIN32
>     return (d == 0 && (_fpclass(d) & _FPCLASS_NZ));
>+#elif defined(SOLARIS)
>+    return (d == 0 && copysign (1, d) < 0);
> #else
>     return (d == 0 && signbit(d));
> #endif
> }

There shouldn't be a space after copysign...

> static inline int
> JSDOUBLE_IS_NEG(jsdouble d)
> {
> #ifdef WIN32
>     return JSDOUBLE_IS_NEGZERO(d) || d < 0;
>+#elif defined(SOLARIS)
>+    return copysign (1, d) < 0;
> #else
>     return signbit(d);
> #endif
> }

...nor here either.

Comment 4

[Leon Sha]

http://hg.mozilla.org/tracemonkey/rev/ec373946e8bf

Comment 5

[Blake Kaplan (:mrbkap) (inactive)]

http://hg.mozilla.org/mozilla-central/rev/ec373946e8bf

Comment 6

[Blake Kaplan (:mrbkap) (inactive)]

http://hg.mozilla.org/mozilla-central/rev/83a487ace308

Comment 7

[Robert Sayre]

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/3629e873d586