Closed
Bug 51326
Opened 24 years ago
Closed 24 years ago
Method findNextInPage(boolean forward) doesn't use its forward parameter
Categories
(Core Graveyard :: Java APIs to WebShell, defect, P3)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: ovk, Assigned: ashuk)
Details
Attachments
(3 files)
669 bytes,
patch
|
Details | Diff | Splinter Review | |
3.00 KB,
application/octet-stream
|
Details | |
1.30 KB,
patch
|
Details | Diff | Splinter Review |
Method findNextInPage(boolean forward) doesn't use its forward parameter (see CurrentPage.cpp) This method use forward parameter, which was set in findInPage(java.lang.String stringToFind, boolean forward, boolean matchCase) method. Possible solutions: 1. Remove forward parameter from this method (change findNextInPage(boolean forward) to findNextInPage()). 2. Use forward parameter in the body of this method. Platform: Webclient source from Sep 04,2000.
Assignee | ||
Comment 2•24 years ago
|
||
Thanks for catching this. However, I am not sure, the FindNextInPage functions should have a "forward" input parameter. This is not in keeping with standard behavior dislayed by either Netscape 4.x/Mozilla or IE. _accept. _Ashu
Status: NEW → ASSIGNED
Assignee | ||
Comment 3•24 years ago
|
||
Assignee | ||
Comment 4•24 years ago
|
||
Comments on http://bugzilla.mozilla.org/showattachment.cgi?attach_id=14416 : You're right it is not consistent to have "forward" param. This is my fault. Nevertheless, let's check this in. r=a=edburns. Please file a separate bug about the incorrectness of the polarity of the API and assign it to ashu.
Reporter | ||
Comment 6•24 years ago
|
||
I submitted the separate bug #52239
Assignee | ||
Comment 7•24 years ago
|
||
Assignee | ||
Comment 8•24 years ago
|
||
FindNextInPage now uses forward parameter. See attached patch. Checked into cvs. _Ashu
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Reporter | ||
Updated•23 years ago
|
Status: RESOLVED → VERIFIED
Reporter | ||
Comment 9•23 years ago
|
||
I mark it as verified.
Updated•12 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•