513380 - [1.9.2 & 1.9.3] Forum Accounts & Groups

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Forums, defect, P1)

Description

[Justin Scott [:fligtar]]

The AMO forums should, at minimum, let users use their existing AMO accounts. For bonus points, the same logged-in session can be used.

We also need to sync user groups between AMO's permission groups (Editors and Admins) and the forum's user groups.

Comment 1

[Wil Clouser [:clouserw]]

Attachment: patch for phpbb

This will let you log in with your AMO _nickname_ and password.  To setup:

- apply the patch
- Log in as admin
- Click "Authentication", choose "Amo" from the drop down, and fill in the amo config
- Hit apply and hope you typed everything right
- Log in with your AMO nickname/password

jbalogh, asking for review from you.  If you want to setup phpbb, go ahead (it's pretty easy) or use my copy (~clouserw/public_html/phpbb) or visually inspect, be happy, and we'll install this on stage and QA can hit it there.

Comment 2

[Jeff Balogh (:jbalogh)]

Comment on attachment 400871 [details] [diff] [review]
patch for phpbb

I thought nothing could make me sadder than cakephp, but here we are.

Your code appears reasonable, though I didn't try running it because I just don't have the heart.

Comment 3

[Wil Clouser [:clouserw]]

wtf!

Comment 4

[Wil Clouser [:clouserw]]

Script is on the forums, but I haven't turned it on yet because we need credentials for preview.amo, bug 516992.

Comment 5

[Wil Clouser [:clouserw]]

Ok, script is live on addons.forums.mozilla.org and appears to be working.  When I log in, all the forums disappear (??) but the auth is working as far as I can tell.  Maybe it's something wrong with default permissions?  Lets get lots of people logging in with different account types to make sure it all works.

Comment 6

[Milos Dinic [:Milos]]

As per IRC chat with Wil, missing forums thing is fixed. Marking this verified.

Comment 7

[Wil Clouser [:clouserw]]

One thing that should be verified by QA is changing nicknames and email addresses.  The code is there to:

Change nickname on AMO -> use new nickname to log in to forums
Change email on AMO -> once confirmed, forum sends mail to that address
Change email on AMO and don't confirm -> you can't log in to the forums (I think.  This is the same case as creating a new account on AMO but never confirming it.  Actually, while I'm on that train of thought, if someone changes their email address, and the "delete users over 2 weeks old that are unconfirmed" cron job runs before they confirm the change, does their account get deleted? hmm)