513658 - Deprecate isReady() in geolocation provider

Status: RESOLVED FIXED

(Core :: DOM: Geolocation, defect)

Description

[Martin McNickle]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-GB; rv:1.9.1.2) Gecko/20090729 Firefox/3.5.2
Build Identifier: 

isReady() isn't used by the geolocation code at all so serves no purpose. Also from discussion:

<dougt> i would be happy to declare isReady as deprecated right now. ;-)

Reproducible: Always

Comment 1

[Martin McNickle]

Attachment: patch

Removed isReady from the idl file. Updated interface UUID. Removes isReady implementations from the bundled providers too.

Will update the docs at https://developer.mozilla.org/En/nsIGeolocationProvider when it lands. Is there anything special to write in the docs to say this was removed (when where why? etc?).

Comment 2

[Doug Turner (:dougt)]

http://hg.mozilla.org/mozilla-central/rev/67a8b17ad2a1

Thanks!!

> Is there anything special to write in the docs to say this was
removed (when where why? etc?).

This was removed because developers found it not required.  (that works for me.  You can also mention this bug).

Comment 3

[Dão Gottwald [:dao]]

This patch doesn't apply on 1.9.2.

Comment 4

[Dão Gottwald [:dao]]

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/540244d8dbb7

Comment 5

[Eric Shepherd [:sheppy]]

Documentation updated:

https://developer.mozilla.org/en/XPCOM_Interface_Reference/NsIGeolocationProvider