513790 - TM: fix incorrect ARGSIZE_LO usages on x64

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: patch

There are a few places we should be using ARGSIZE_P instead.

Comment 1

[Jason Orendorff [:jorendorff]]

Comment on attachment 397729 [details] [diff] [review]
patch

Nanojit now offers nicer ARGSIZE_ constants than when I originally wrote this.

So please instead change it like this:

>#define _JS_I32_ARGSIZE    nanojit::ARGSIZE_I
>#define _JS_I32_RETSIZE    nanojit::ARGSIZE_I
>#define _JS_F64_ARGSIZE    nanojit::ARGSIZE_Q
>#define _JS_F64_RETSIZE    nanojit::ARGSIZE_Q
>#define _JS_PTR_ARGSIZE    nanojit::ARGSIZE_P
>#define _JS_PTR_RETSIZE    nanojit::ARGSIZE_P

For bonus points remove the bogus distinction between ARGSIZE and RETSIZE. It looks like it's no longer needed.

r=me with that.

Comment 2

[Jason Orendorff [:jorendorff]]

Actually ... for that matter, we shouldn't use ARGSIZE_LO anywhere. Please change the remaining few to ARGSIZE_I.

Comment 3

[David Anderson [:dvander] - inactive, e-mail if emergency]

http://hg.mozilla.org/tracemonkey/rev/b4d46d7b59cc

Comment 4

[Blake Kaplan (:mrbkap) (inactive)]

http://hg.mozilla.org/mozilla-central/rev/b4d46d7b59cc

Comment 5

[Robert Sayre]

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/a0f1ac4a526e