513820 - Remove Cookies button is not cleared when cookie list is cleared

Status: RESOLVED WORKSFORME

(Firefox :: Settings UI, defect)

Description

[Aakash Desai [:aakashd]]

Build Id: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a2pre) Gecko/20090831 Namoroka/3.6a2pre ID:20090831034605

and 

Build identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1.2) Gecko/20090729 Firefox/3.5.2

Steps to Reproduce:
1. Go to the privacy pane
2. Click on custom settings and go to the cookies manager
3. Empty out the list of cookies 
4. uncheck "Accept cookies from sites" as well
5. Go to any site and open up the preferences dialog
6. go to the cookies manager

Actual results:
The list of cookies is empty, but the "remove cookies" button is enabled.

Expected Results:
The list of cookies is empty and the "remove cookies" button is disabled.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

This bug affects one of our Mozmill tests. We have a workaround for now but I wonder if we can get this fixed.

Daniel, do you know who owns the cookies ui in the preferences manager?

Comment 2

[[e-mail]]

No one, really. Sounds trivial. You could probably see if Ehsan or Paul feel like fixing it...

Comment 3

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

Attachment: Patch v0.1

BAM! I think that's all that's needed, but I haven't looked at that code until just now, so perhaps I'm missing some cases. I hand tested the cases i could think up and all looked fine.

Comment 4

[[e-mail]]

Comment on attachment 434414 [details] [diff] [review]
Patch v0.1

Hmm. Isn't this bug about "removeCookies", not "removeAllCookies"?

From code inspection, (and I'm guessing here), it looks like we never disable "removeCookies" in _loadCookies() if the list is empty. Maybe it gets disabled elsewhere, but if not, could that be the problem?

Comment 5

[[e-mail]]

Oh. Ha. There are two bugs here: "removeAllCookies" doesn't disable on empty load or on clicking it, and "removeCookies" doesn't disable on load (but *does* after clicking "removeAllCookies").

Your patch fixes the first. (I think... does it fix the empty load case?)

Maybe it fixes the second because there's some logic to couple "removeAllCookies" to "removeCookies"? There must be somewhere, given the behavior.

Comment 6

[[e-mail]]

Comment on attachment 434414 [details] [diff] [review]
Patch v0.1

Minusing based on comments.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Paul, any update for this bug? I know it's not that important but it will fix one of our Mozmill tests so we can clearly test the ui bits.

Comment 8

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

No update. Probably won't happen in the 4.0 timeframe given it's low priority and the fact that we've already shipped with this bug before.

Comment 9

[:Gijs (he/him)]

This now works in the "manage data" site data dialog. The cookie management dialog with this issue has been removed.