514013 - Move devhub pages to a new controller so they're not login-protected

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect, P1)

Comment 1

[Jeff Balogh (:jbalogh)]

Attachment: moving devhub static pages to a new controller

--comment=Ideally, this would go in when there are no incoming patches for these pages because the renames are going to throw off svn.  If only there was a vcs that could handle renames...

Comment 2

[Fred Wenzel [:wenzel]]

Hm? SVN does handle renames.

Comment 3

[Wil Clouser [:clouserw]]

Comment on attachment 398788 [details] [diff] [review]
moving devhub static pages to a new controller

The concept is fine, so I'm r+ing, but use `svn mv` to move the files. (or I can if you don't have an svn checkout handy).

Comment 4

[Jeff Balogh (:jbalogh)]

(In reply to comment #3)
> (From update of attachment 398788 [details] [diff] [review])
> The concept is fine, so I'm r+ing, but use `svn mv` to move the files. (or I
> can if you don't have an svn checkout handy).

I don't have anything with svn, can you apply this patch and move the files the right way?  Thanks.

Comment 5

[Wil Clouser [:clouserw]]

r51361.  Somewhat untested but I figured it will get lots of testing elsewhere.  QA: We just want to make sure the /developers/ URLs still work, and double check the search too.

Comment 6

[Justin Scott [:fligtar]]

I moved the hub index to the new controller in r51370.

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED; I tested as requested in comment 5.  (https://preview.addons.mozilla.org/en-US/developers/addon/validate intentionally requires login, as expected.)

Comment 8

[Justin Scott [:fligtar]]

Actually, that's not expected. Validator is open to everyone. You have to be logged in to actually upload an add-on or select one of your existing add-ons, but you should be able to load the page and read what it is, as described in bug 513135. But please file a new bug for it.

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #8)
> Actually, that's not expected. Validator is open to everyone. You have to be
> logged in to actually upload an add-on or select one of your existing add-ons,
> but you should be able to load the page and read what it is, as described in
> bug 513135. But please file a new bug for it.

Filed bug 516904, thanks!