514198 - freetype2 (cairo) doesn't compile on m-1.9.1

Status: VERIFIED FIXED

(Core :: Graphics, defect)

Description

[Serge Gautherie (:sgautherie)]

m-c:
make -B -C objdir/modules/freetype2
builds fine.


m-1.9.1:
make -B -C objdir/gfx/cairo/cairo/src
{
cairo-ft-font.c
\gfx\cairo\cairo\src\cairo-platform.h(53) : warning C4005: 'cairo_public' : macro redefinition
        \gfx\cairo\cairo\src\cairoint.h(54) : see previous definition of 'cairo_public'
\gfx\cairo\cairo\src\cairo-ft.h(49) : fatal error C1083: Cannot open include file: 'ft2build.h': No such file or directory
make[1]: *** [cairo-ft-font.obj] Error 2
make[1]: Leaving directory `objdir/gfx/cairo/cairo/src'
}

I initially tried on ThunderbirdTry:
{
http://tinderbox.mozilla.org/showlog.cgi?log=ThunderbirdTry/1251848210.1251859669.21738.gz&fulltext=1

d:\buildbot\sendchange-win32-hg\mozilla\mozilla\gfx\cairo\cairo\src\cairo-ft.h(49) : fatal error C1083: Cannot open include file: 'ft2build.h': No such file or directory
}
(and I filed bug 514058 too...)

***

At first glance, it would look like, m-1.9.1 either:
should not have "Bug 462908 - Implement Freetype font backend for windows ce" or should be disabled for windows desktop or something,
or is missing "Bug 463532 - import freetype into the tree".

Comment 1

[Peter Weilbacher]

What's your configuration? I don't think cairo should be configured to enable the FreeType backend by default on Windows. Do you have the FreeType _library_ installed on your machine but are missing the developer portion (the headers)?

Comment 2

[Serge Gautherie (:sgautherie)]

I noticed m-1.9.1 misses
http://mxr.mozilla.org/mozilla1.9.2/source/modules/freetype2/
though --enable-tree-freetype is available.
I tried the latter because I wanted to try and clean it up in c-c.

As I see it, m-1.9.1 is
*either missing the in-tree freetype2,
*or missing some configure check to detect there is no external library available
 (unless it should not even have that option?).

Comment 3

[JP Rosevear [:jpr]]

As part of bug 609114 we block freetype2 in tree builds for MSVC

Comment 4

[Serge Gautherie (:sgautherie)]

m-1.9.1 is long dead.

Trying to build Firefox 12a1 with '--enable-tree-freetype' and VC8EE returns:
{
configure: error: building with in-tree freetype is not supported on MSVC
}
as now expected.

V.Fixed