514230 - test_focus.xul makes incorrect assumptions about getElementById

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Boris Zbarsky [:bzbarsky]]

I had to disable dom/tests/mochitest/chrome/test_focus.xul, because it was relying on a bug in getElementById.  It's not clear to me offhand how this test _should_ work, exactly...

The bug it was relying on was returning XBL anonymous nodes from getElementById.  Maybe we should be passing around nodes, not ids, more?

Comment 1

[Neil Deakin]

(In reply to comment #0)
> I had to disable dom/tests/mochitest/chrome/test_focus.xul, because it was
> relying on a bug in getElementById.  It's not clear to me offhand how this test
> _should_ work, exactly...

Can you disable just the part that does this? This part is from the comment 'tests to check if tabbing out of a textbox works' to the last call to expectFocusShift.

http://mxr.mozilla.org/mozilla-central/source/dom/tests/mochitest/chrome/window_focus.xul#736

I think there was some reason why ids were used instead of elements, but don't recall what it was. I'll investigate or just create some other mechanism for this part of the test.

Comment 2

[Boris Zbarsky [:bzbarsky]]

> Can you disable just the part that does this?

I can do that if I don't figure out a quick way to make this work otherwise.  Looking at it now.

Comment 3

[Neil Deakin]

Attachment: change to use elements rather than ids

Also fixes a problem caused by bug 504533 on Mac with the Full Keyboard Access setting is 'all' (not the default on test machines) because tabs are now focusable.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

(In reply to comment #3)
> Also fixes a problem caused by bug 504533
Wrong bug number?

Comment 5

[Neil Deakin]

Sorry, I meant 491636.

Comment 6

[Neil Deakin]

http://hg.mozilla.org/mozilla-central/rev/fc5cc68df731

Comment 7

[Boris Zbarsky [:bzbarsky]]

I pushed a merge of this to 1.9.2 branch as http://hg.mozilla.org/releases/mozilla-1.9.2/rev/9c6a2eb24042 because otherwise the fix for bug 489925 was making it orange...  I hope I got the merging right.  ;)