514388 - No quit dialog when multiple windows are open

Status: RESOLVED FIXED

(SeaMonkey :: Session Restore, defect)

Description

[[e-mail]]

nsSuiteGlue.js has a reference to chrome://browser/locale/quitDialog.properties but this file does not exist in SeaMonkey. Instead we need to create one in the communicator locale and update nsSuiteGlue.js to point to it.

Comment 1

[Robert Kaiser]

I wonder if we might actually have the strings in one of our files already and just missed to correct the URL, actually.

Comment 2

[Misak Khachatryan]

Actually suite/locales/en-US/chrome/common/quitDialog.properties file was missing, so string changes required :(

Comment 3

[Misak Khachatryan]

Attachment: fix [Checkin: Comment 6]

Comment 4

[Misak Khachatryan]

also we might want to port Bug 354894 too, I'll do it after beta 2

Comment 5

[Robert Kaiser]

You can't block 2.0b2 any more, it has been cut, but yes, we want this for 2.0

Comment 6

[Serge Gautherie (:sgautherie)]

Comment on attachment 398595 [details] [diff] [review]
fix
[Checkin: Comment 6]


http://hg.mozilla.org/comm-central/rev/f5f47aae6455

Comment 7

[Misak Khachatryan]

This fix was working for me at the moment of submitting, but somehow not now :( Current behavior is on quit SM prompts tab close warning for each window and then quit prompt. Can't figure out why.

Comment 8

[Misak Khachatryan]

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.4pre) Gecko/20090907 NOT Firefox/2.0.0.20 Lightning/1.0pre SeaMonkey/2.0pre ID:20090907094702


Sorry, forgot my Build iD

Comment 9

[[e-mail]]

It's random, unfortunately; it just depends on whether nsSuiteGlue or nsTryToClose has been registered first. (nsTryToClose is the component that calls the individual prompt for each window.)

Comment 10

[[e-mail]]

So, according to gavin, Firefox doesn't set window.tryToClose in its browsers, so that only session restore prompts when you're trying to quit.

Comment 11

[Misak Khachatryan]

Yes, figured that out too, fix is in patch for bug 515006

Comment 12

[Misak Khachatryan]

Attachment: don't set window.tryToClose in browser

It seems this one liner is fixing this bug. No need to wait for bug 515006

Comment 13

[[e-mail]]

Comment on attachment 399397 [details] [diff] [review]
don't set window.tryToClose in browser

This isn't quite right, you need to change BrowserTryToCloseWindow too.

Comment 14

[Misak Khachatryan]

Attachment: right fix [Checkin: Comment 15]

Sorry, this is the right one.

Comment 15

[Serge Gautherie (:sgautherie)]

Comment on attachment 399425 [details] [diff] [review]
right fix
[Checkin: Comment 15]


http://hg.mozilla.org/comm-central/rev/d45144dc165c

Comment 16

[[e-mail]]

Hello,

Do I take it that the old feature to give a warning dialog box before quitting when multiple windows or tabs are open is supposed to have been restored? I am running 
Build identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.1.7) Gecko/20100105 SeaMonkey/2.0.2

... and keep accidentally quitting with no dialog when hitting Command-Q by mistake (intending Command-W).

Comment 17

[[e-mail]]

(In reply to comment #16)
> Do I take it that the old feature to give a warning dialog box before quitting
> when multiple windows or tabs are open is supposed to have been restored?
Yes, unless your startup preference is set to restore previous session.