Closed Bug 514551 Opened 15 years ago Closed 15 years ago

nanojit: avoid using ~allocator.free

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
status1.9.2 --- beta1-fixed

People

(Reporter: n.nethercote, Assigned: n.nethercote)

References

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 file)

patch
4.76 KB, patch
edwsmith
: review+
Details | Diff | Splinter Review 
We have evictRegs(~allocator.free) in several places in Assembler.cpp.  It means "evict all active registers" and works but is dodgy because 'free' and 'active' aren't complementary (there's a 3rd class of "unmanaged" registers).

Probably the best thing to do is to create evictActiveRegs().  It might even be slightly faster as it avoids the is-it-in-the-RegisterMask test for each register.
Blocks: 513616
Attached patch patch — — Splinter Review 

        Attachment #399155 -
        Flags: review?(edwsmith)

    
  

        Attachment #399155 -
        Flags: review?(edwsmith) → review+

    
    

    
  
http://hg.mozilla.org/tracemonkey/rev/19b5d858f40c
Whiteboard: fixed-in-tracemonkey

    
    

    
  
http://hg.mozilla.org/mozilla-central/rev/19b5d858f40c
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: