514630 - cannot bookmark pages using drag&drop

Status: RESOLVED FIXED

(SeaMonkey :: Bookmarks & History, defect)

Description

[Rolf Bode-Meyer]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.9.1.4pre) Gecko/20090903 SeaMonkey/2.0b2pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.9.1.4pre) Gecko/20090903 SeaMonkey/2.0b2pre

In nightly 20090831 it worked, in 20090903 it doesn't anymore.


Reproducible: Always

Steps to Reproduce:
1. Load a page.
2. Drag its icon in the address bar into the personal toolbar or the bookmark manager window.
Actual Results:  
During drag I get an insertion cursor but after drop nothing happens.

Expected Results:  
Bookmark for site should get inserted into bookmark list.

Comment 1

[Philip Chee]

Error: Component returned failure code: 0x80004003 (NS_ERROR_INVALID_POINTER) [nsIRDFContainer.Init]
Source file: chrome://communicator/content/bookmarks/bookmarks.js
Line: 1393

I think this is a regression caused by Bug 342296

Comment 2

[[e-mail]]

Attachment: Detect insertions

This just checks that the whole selection is movable, and if not, inserts it.

Comment 3

[[e-mail]]

Attachment: Emulate old behaviour [Checkin: See comment 12]

The old behaviour was to try and delete as much of the selection as possible.

Thus the effect was to move where possible, and insert otherwise.

Comment 4

[Ian Neal]

Comment on attachment 398689 [details] [diff] [review]
Emulate old behaviour
[Checkin: See comment 12]

Could you stick a var before the i in line 1240 whilst you're at it?

Comment 5

[Rolf Bode-Meyer]

Requesting blocker for b2, this is a really annoying bug.

Comment 6

[Robert Kaiser]

Not blocking a beta on this, bookmarks still can be added via the menus. Blocking final sounds reasonable though, marking that.

Comment 7

[Dave Buco]

Don't know if this is related, but using the menu bar > bookmarks > bookmark this page, and/or right click page > bookmark this page does not work correctly. No options are given as to where to place the bookmark. It is placed generically and not in personal toolbar as previously.  It can only be found by clicking menu bar > bookmarks dropdown. 

See image here: http://i27.tinypic.com/2whgspx.jpg

Comment 8

[Dave Buco]

Ooops. forgot build ID for above..

Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.1.4pre) Gecko/20090905 SeaMonkey/2.0pre - Build ID: 20090905005746

Comment 9

[Robert Kaiser]

(In reply to comment #7)
> Don't know if this is related, but using the menu bar > bookmarks > bookmark
> this page, and/or right click page > bookmark this page does not work
> correctly. No options are given as to where to place the bookmark. It is placed
> generically and not in personal toolbar as previously.  It can only be found by
> clicking menu bar > bookmarks dropdown.

That's intended functionality. Only drag&drop or "File Bookmark..." can place items in the personal toolbar.

Comment 10

[Dave Buco]

OK. Thanks for the clarification, Robert.

Comment 11

[[e-mail]]

(In reply to comment #7)
> No options are given as to where to place the bookmark.
Open the Bookmarks Manager, then choose the desired folder and select
View - Set as New Bookmark Folder.

Comment 12

[[e-mail]]

Pushed changeset 5cd46484def2 to comm-central.

Comment 14

[roman toledo]

I still have this problem in Build identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.4pre) Gecko/20090903 SeaMonkey/2.0b2

I do not see a plain 2.0 for download that says it's fixed. so I'm confused where is 2.0  not the beta version that has this problem fixed?

Comment 15

[Robert Kaiser]

roman, it's fixed in current nightly versions that are on the way to 2.0 final, and so it will be fixed in the real 2.0 when it actually appears.