Closed
Bug 514667
Opened 15 years ago
Closed 15 years ago
Let Mochitest run on IE
Categories
(Testing :: Mochitest, defect)
Testing
Mochitest
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.9.3a1
People
(Reporter: sylvain.pasche, Assigned: sylvain.pasche)
References
Details
(Whiteboard: [fixed1.9.2b1 fixed1.9.1.4])
Attachments
(1 file, 2 obsolete files)
3.18 KB,
patch
|
sayrer
:
review+
|
Details | Diff | Splinter Review |
A const slipped in SimpleTest.js from bug 494397.
Attachment #398655 -
Flags: review?(sayrer)
Updated•15 years ago
|
Attachment #398655 -
Flags: review?(sayrer) → review+
Comment 1•15 years ago
|
||
Comment on attachment 398655 [details] [diff] [review] use var instead of const. It looks like you did not prepare this patch against m-c trunk... Please, add a comment about this at the top of the file.
Assignee | ||
Comment 2•15 years ago
|
||
(In reply to comment #1) > (From update of attachment 398655 [details] [diff] [review]) > > It looks like you did not prepare this patch against m-c trunk... oops, yeah my tree was a few days old. > Please, add a comment about this at the top of the file. How does this sound? + * NOTE: Pay attention to cross-browser compatibility in this file. For + * instance, do not use const or JS > 1.5 features which are not yet + * implemented everywhere. + *
Assignee: nobody → sylvain.pasche
Attachment #398655 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Comment 3•15 years ago
|
||
(In reply to comment #2) > How does this sound? > > + * NOTE: Pay attention to cross-browser compatibility in this file. For > + * instance, do not use const or JS > 1.5 features which are not yet > + * implemented everywhere. > + * That should be just fine. (NB: Though now I wonder about the other files: in SimpleTest/, and all our tests. Maybe we will see about this when we start to upstream our changes to MochiKit...)
Assignee | ||
Comment 4•15 years ago
|
||
Yeah, there may be some issues in the other files. If I open http://localhost:8000/tests and click "Run Tests", there's an exception in IE.
Keywords: checkin-needed
Comment 5•15 years ago
|
||
Oh :-( Which exception? Then I would suggest to fix all SimpleTest/* at the same time...
Assignee | ||
Comment 6•15 years ago
|
||
Message: 'undefined' is null or not an object Line: 3027 Char: 1 Code: 0 URI: http://localhost:8888/MochiKit/packed.js ok, I can try to find the issue and maybe do a single patch.
Assignee | ||
Comment 7•15 years ago
|
||
Two more things: - fallback to testFrame.contentWindow.document if testFrame.contentDocument is unavailable - innerHTML instead of textContent With that the harness should be able to run tests on IE 8.
Attachment #398669 -
Attachment is obsolete: true
Attachment #399598 -
Flags: review?(sayrer)
Updated•15 years ago
|
Attachment #399598 -
Flags: review?(sayrer) → review+
Comment 8•15 years ago
|
||
Comment on attachment 399598 [details] [diff] [review] patch, v2 [Checkin: Comment 8 & 9 & 10] http://hg.mozilla.org/mozilla-central/rev/62f6012a7e6c
Attachment #399598 -
Attachment description: patch, v2 → patch, v2
[Checkin: Comment 8]
Updated•15 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Whiteboard: [c-n: m-1.9.2, m-1.9.1]
Target Milestone: --- → mozilla1.9.3a1
Comment 9•15 years ago
|
||
Comment on attachment 399598 [details] [diff] [review] patch, v2 [Checkin: Comment 8 & 9 & 10] http://hg.mozilla.org/releases/mozilla-1.9.2/rev/631b49078b78
Attachment #399598 -
Attachment description: patch, v2
[Checkin: Comment 8] → patch, v2
[Checkin: Comment 8 & 9]
Updated•15 years ago
|
Whiteboard: [c-n: m-1.9.2, m-1.9.1] → [c-n: m-1.9.1]
Updated•15 years ago
|
Whiteboard: [c-n: m-1.9.1] → [c-n: m-1.9.1] [fixed1.9.2b1]
Comment 10•15 years ago
|
||
Comment on attachment 399598 [details] [diff] [review] patch, v2 [Checkin: Comment 8 & 9 & 10] http://hg.mozilla.org/releases/mozilla-1.9.1/rev/db61be37d6c7
Attachment #399598 -
Attachment description: patch, v2
[Checkin: Comment 8 & 9] → patch, v2
[Checkin: Comment 8 & 9 & 10]
Updated•15 years ago
|
Keywords: checkin-needed
Whiteboard: [c-n: m-1.9.1] [fixed1.9.2b1] → [fixed1.9.2b1 fixed1.9.1.4]
You need to log in
before you can comment on or make changes to this bug.
Description
•