514833 - [Mac] Full Screen button not shown in 'Show: Text' mode

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[KENZ (Kenji Irie)]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; ja; rv:1.9.3a1pre) Gecko/20090904 Minefield/3.7a1pre
Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; ja; rv:1.9.3a1pre) Gecko/20090904 Minefield/3.7a1pre

Full Screen button displays incorrectly (it takes some space, but doesn't show text 'Full Screen') with toolbar mode 'Show: Text' (changed from Toolbar customize dialog) in full screen mode.

Reproducible: Always

Steps to Reproduce:
1. Open Toolbar customize dialog
2. 'Restore Default Set'
3. Select 'Show: Text' then close the dialog.
4. Make window full screen (with shortcut 'Command + Shift + F')
5. Look rightmost area of the toolbar.
Actual Results:  
There is space for the full screen button, but doesn't show text.

Expected Results:  
Full screen button with text 'Full Screen' or so.

Comment 1

[KENZ (Kenji Irie)]

Sorry, in full screen mode, the button should show 'Restore' text.

Comment 2

[Markus Stange [:mstange]]

Good find!

Comment 3

[AKIHIRO Misaki (a.k.a Kuden)]

These two rules are necessary.

http://hg.mozilla.org/mozilla-central/annotate/2600b11db971/browser/themes/winstripe/browser/browser.css#l1527

toolbar[mode="text"] > #window-controls > toolbarbutton > .toolbarbutton-icon {
 display: -moz-box;
}

toolbar[mode="text"] > #window-controls > toolbarbutton > .toolbarbutton-text {
 display: none;
}

Comment 4

[KENZ (Kenji Irie)]

Attachment: Screenshot shows the bug.

Comment 5

[Dão Gottwald [:dao]]

(In reply to comment #3)
> These two rules are necessary.
> 
> http://hg.mozilla.org/mozilla-central/annotate/2600b11db971/browser/themes/winstripe/browser/browser.css#l1527
> 
> toolbar[mode="text"] > #window-controls > toolbarbutton > .toolbarbutton-icon {
>  display: -moz-box;
> }
> 
> toolbar[mode="text"] > #window-controls > toolbarbutton > .toolbarbutton-text {
>  display: none;
> }

This actually belongs in browser/base/content/browser.css.

Comment 6

[AKIHIRO Misaki (a.k.a Kuden)]

(In reply to comment #5)
> (In reply to comment #3)
> This actually belongs in browser/base/content/browser.css.

Is this also so?

http://hg.mozilla.org/mozilla-central/annotate/2600b11db971/browser/themes/winstripe/browser/browser.css#l1523

toolbar[mode="text"] toolbarbutton.chevron > .toolbarbutton-icon {
 display: -moz-box; /* display chevron icon in text mode */
}

Comment 7

[KENZ (Kenji Irie)]

(In reply to comment #2)
> Good find!

Originally Kuden-san finds this. I've just reported it. Good catch!

Comment 8

[Dão Gottwald [:dao]]

(In reply to comment #6)
> (In reply to comment #5)
> > (In reply to comment #3)
> > This actually belongs in browser/base/content/browser.css.
> 
> Is this also so?
> 
> http://hg.mozilla.org/mozilla-central/annotate/2600b11db971/browser/themes/winstripe/browser/browser.css#l1523
> 
> toolbar[mode="text"] toolbarbutton.chevron > .toolbarbutton-icon {
>  display: -moz-box; /* display chevron icon in text mode */
> }

Not necessarily, there's also a toolbarbutton-menu-dropmarker which a theme might want to display instead.

Comment 9

[Markus Stange [:mstange]]

Attachment: v1

Comment 10

[Dão Gottwald [:dao]]

Comment on attachment 399020 [details] [diff] [review]
v1

>+#navigator-toolbox[inFullscreen="true"] #fullscr-toggler,

this should use ">"

>+toolbar[mode="text"] > #window-controls > toolbarbutton > .toolbarbutton-icon {

this should use #nav-bar

Comment 11

[Markus Stange [:mstange]]

http://hg.mozilla.org/mozilla-central/rev/1e2b034670d9

Comment 12

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Markus, why do we still show the button while we are in text mode? Shouldn't all buttons be displayed as text?

Comment 13

[AKIHIRO Misaki (a.k.a Kuden)]

(In reply to comment #12)
> Markus, why do we still show the button while we are in text mode? Shouldn't
> all buttons be displayed as text?

I also think so. 
However, I think that it is another bug.

Comment 14

[Dão Gottwald [:dao]]

Minimize, restore and close originally mimicked window controls (they still do on Windows and Linux), and those are always just icons.

Comment 15

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Ok, that would make sense.

Verified fixed with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.3a1pre) Gecko/20090908 Minefield/3.7a1pre ID:20090908030622

Comment 16

[Markus Stange [:mstange]]

(In reply to comment #12)
> Markus, why do we still show the button while we are in text mode? Shouldn't
> all buttons be displayed as text?

That would definitely make sense since we don't mimic window controls on OS X.

Comment 17

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to comment #16)
> That would definitely make sense since we don't mimic window controls on OS X.

Does it mean we should file a new bug on that? Probably I cannot interpret your answer correctly.

Comment 18

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 399020 [details] [diff] [review]
v1

a192=beltzner

Comment 19

[Markus Stange [:mstange]]

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/44e34af04e51

Comment 20

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Verified fixed on 1.9.2 with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2b1pre) Gecko/20090922 Namoroka/3.6b1pre ID:20090922041132

Comment 21

[Marcia Knous [:marcia]]

https://litmus.mozilla.org/show_test.cgi?id=9534 added to litmus.

Comment 22

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Probably we should have been reopened that one a month ago. Now that it is a bit too late I have filed bug 522140 as a follow-up.