515049 - [Collector Extension] No Credits in About

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Collector Extension, defect, P3)

Description

[Brian King [:kinger]]

Attachment: Person-less About

Credits are missing in About, but present in install.rdf. See acreenshot.

Comment 1

[Brian King [:kinger]]

This is logged as item 1 in bug 394999. Worthy of a bug on its own I think.

What I basically discovered is that, if there are em:localized blocks in install.rdf, none of the following properties are recognised unless they are put inside the localized block.

creator, contributor, developer, translator, homepageURL

I can see a case being made for translator, but all the others should be global.

Dave, am I missing something?

Comment 2

[David McNamara [:mackers]]

The only other properties are these:

version
optionsURL
iconURL

and they are all working as expected.

Comment 3

[Dave Townsend [:mossop]]

The problem is that some people wanted the properties to be additive, some wanted them to fallback to the global and some wanted them to completely separate. With the way it is implemented right now everyone can get the effect they want though it may cause some duplication, much of which can be got around by using entities to define the shared items.

Comment 4

[Brian King [:kinger]]

(In reply to comment #3)
> The problem is that some people wanted the properties to be additive, some
> wanted them to fallback to the global and some wanted them to completely
> separate. With the way it is implemented right now everyone can get the effect
> they want though it may cause some duplication, much of which can be got around
> by using entities to define the shared items.

We'll go with this workaround for now.

Comment 5

[Brian King [:kinger]]

(In reply to comment #4)
> We'll go with this workaround for now.

Checked in, r51114.

Removing dependency, but noting bug 416350

Marking FIXED.

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Post-fix/workaround screenshot

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED.