515072 - Enhance controller.assertJS to output relevant context for pass/fail states

Status: VERIFIED FIXED

(Testing Graveyard :: Mozmill, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Patch

At the moment assertJS doesn't output any useful information in the output which could be used to track down failures in a test. As more tests you will have as more difficult it is to identify the failing assertJS call. That's why we should change the output string for this function and add the expression itself.

Therefor we could use the same way as we already have for waitForEval. Let's specify a subject if needed which can be used to get access to members.

controller.assertJS("subject.currentStep == 'updatesfound'", update);

In this example currentStep is a member variable of the update instance. If the evaluation fails you will see the following entry in the output pane:

fail :: Controller.assertJS("subject.currentStep == 'updatesfound'")

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Mikeal, can we please get a process on this bug?

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Updated to Git:
http://github.com/whimboo/mozmill/commit/d6d2822402abc439e1d9cffaa3023a618a54bdc6

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Merged to the master.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

No regressions seen so far. All existing assertJS calls work like expected. Marking verified.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Docs are already uptodate.