515213 - Need to handle DOMWillOpenModalDialog

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[:Gavin Sharp [email: [e-mail]]]

Otherwise background tabs can open alerts over the selected tab.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

(bug 277574 is the original core/firefox bug)

Comment 2

[:Gavin Sharp [email: [e-mail]]]

also bug 262887

Comment 3

[Benjamin Stover (:stechz)]

Attachment: Implement by adding event listener in _createBrowser

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 401975 [details] [diff] [review]
Implement by adding event listener in _createBrowser

Can you add the listener here:
http://mxr.mozilla.org/mobile-browser/source/chrome/content/browser-ui.js#389

Add the handler as a member of BrowserUI.

Drop the | let targetTop = new XPCNativeWrapper(e.target, "top").top; | and use | let targetTop = event.target.top; | that the newest tabbrowser.xml code uses:
http://mxr.mozilla.org/mozilla-central/source/browser/base/content/tabbrowser.xml#2784

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Oh, here is a piece of bad news: "DOMWillOpenModalDialog" and "DOMModalDialogClosed" are fired by nsAutoWindowStateHelper found here:
http://mxr.mozilla.org/mozilla-central/source/embedding/components/windowwatcher/src/nsAutoWindowStateHelper.cpp#52

Which is heavily used in nsPromptService:
http://mxr.mozilla.org/mozilla-central/ident?i=nsAutoWindowStateHelper

Of course, Fennec overrides the nsPromptService and doesn't currently fire the event :(

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

Let's get this patch ready for listening and handling the event. We can open another bug for firing the event.

Filed bug 518054

Comment 7

[Benjamin Stover (:stechz)]

Attachment: Listen for event in correct place

Cool, I did not know addEventListener will call handleEvent on an object.

Comment 8

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
https://hg.mozilla.org/mobile-browser/rev/a5c85d5f25a2

This still needs bug 518054 to work completely.