Closed
Bug 515874
Opened 15 years ago
Closed 15 years ago
TM: add a way to flush CodeAllocs without deleting/recreating [nanojit]
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: gal, Assigned: gal)
Details
(Whiteboard: fixed-in-tracemonkey)
Attachments
(1 file)
|
2.55 KB,
patch
|
graydon
:
review+
|
Details | Diff | Splinter Review |
VMAllocators can already do this.
|
Assignee | |
Comment 1•15 years ago
|
||
Assignee: general → gal
|
|
Assignee | |
Updated•15 years ago
|
Attachment #399960 -
Flags: review?(graydon)
|
||
Updated•15 years ago
|
Attachment #399960 -
Flags: review?(graydon) → review+
|
|
||
Comment 2•15 years ago
|
||
Code looks fine and harmless, may as well. Odd though, is this needed for making Assemblers short-lived? I'd have thought the opposite: that making them short-lived would *remove* the need for any kind of reset function (which plainly we're making-do without, presently).
|
|
Assignee | |
Comment 3•15 years ago
|
||
The assembler and filter create temporary data, which we will allocate from a tempAlloc in the compiler (TraceRecorder and NativeRegExpCompiler). There the allocator will simply be destroyed. For the dataAlloc (currently allocator) and codeAlloc we can use reset().
|
|
Assignee | |
Updated•15 years ago
|
Summary: add a way to flush CodeAllocs without deleting/recreating [nanojit] → TM: add a way to flush CodeAllocs without deleting/recreating [nanojit]
|
|
Assignee | |
Comment 4•15 years ago
|
||
http://hg.mozilla.org/tracemonkey/rev/01fc5bf1d21a
Whiteboard: fixed-in-tracemonkey
|
||
Comment 5•15 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/01fc5bf1d21a
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•