516102 - Refactor XPCNativeWrapperCtor into C++ callable and JS callable versions

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Blake Kaplan (:mrbkap) (inactive)]

Right now, XPCNativeWrapperCtor can be called by both JS and C++, which is confusing (and looking at cx->fp if we weren't called from JS is simply wrong).

Comment 1

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Fix

Comment 2

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: With a test

Comment 3

[Johnny Stenback (:jst)]

Comment on attachment 400689 [details] [diff] [review]
With a test

+    try {
+        is(new XPCNativeWrapper(window, Window).closed, false,
+           "able to wrap a window in a window XPCNativeWrapper");
+        new XPCNativeWrapper(document, Window);

The first of those two tests should be outside of the try shouldn't it?

r+sr=jst with that.

Comment 4

[Blake Kaplan (:mrbkap) (inactive)]

http://hg.mozilla.org/mozilla-central/rev/7e8e1dd4e8e6