51637 - Up arrow in URL bar clears the URL field

Status: VERIFIED FIXED

(SeaMonkey :: Location Bar, defect, P5)

Description

[Simon Fraser [no longer active]]

In a new browser window, which has loaded a page by default (e.g. mozilla.org), 
pressing the up arrow clears the url bar. It should not.

It appears that the url bar history is messed up; the dropdown list always 
contains just one blank item, and I suspect that this empty string is being put 
into the URL bar.

Comment 1

[Asa Dotzler [:asa]]

*** Bug 60332 has been marked as a duplicate of this bug. ***

Comment 2

[Adam]

I see this in any browser window (not just newly opened ones that loaded the
default page). Annoying because there's no way to get the URL back. The only
time this doesn't happen is when the dropdown list has been accessed (using the
up/down arrow keys then scrolls through the URLs contained in that list).

Comment 3

[Blake Ross]

Radha, I can take a look at this when I get some time, if you want.

Comment 4

[Radha on family leave (not reading bugmail)]

This is related to the behavior of the GFX widget. Maybe Simon can throw some
light here. I think that I also have another bug similar to this

Comment 5

[Simon Fraser [no longer active]]

What do the mean by the "behaviour of the GFX widget"? The text widgets don't 
respond to up arrow by removing text.

Comment 6

[Vincent Schut]

Just to be complete: the down arrow also clears the url bar.

Comment 7

[Viswanath Ramachandran]

nav triage: 4xp, p4. 

Comment 8

[Alec Flett]

moving these bugs to History: URLBar

Comment 9

[Paul Chen]

nav triage team:

Marking nsbeta1+

Comment 10

[Paul Chen]

nav triage team:

Putting on the backburner, though we should decided what up and down arrow
SHOULD do for the product. Removing nsbeta1+, marking p5 and future

Comment 11

[Blake Ross]

Attachment: [patch] make sure we have an autocomplete popup first

Comment 12

[Blake Ross]

cc'ing ducarroz for review

Comment 13

[timeless]

r=timeless
please fix tabs in the two lines following your patch

Comment 14

[Jean-Francois Ducarroz]

Please wait on my review before check it in...

Comment 15

[Jean-Francois Ducarroz]

If I correctly undestand your patch, the keynavigation is responsible for
clearing the URL bar. Therefore your fix is to do keynavigation only when the
popup menu is open. Right?

In this case I will have to refuse this patch as we will lost the posibility of
using autocompletion without dropdown list which can be set with a special
attribute on the input field. The right fix is to avoid keyNavigation when there
is not valid entry.

Comment 16

[Blake Ross]

What attribute is this and why would we ever want to do that?  What could be 
more dangerous (and surprising) than changing a textfield to a completely 
different value, without the possibility of undo, when the user thinks he's 
just navigating the textfield (since that's how most other textfields in the 
product work), and there's no indication that autocomplete is kicking in?

Comment 17

[Matthew T (active 1999-2002)]

When there are no auto-completions available for a given text field, Up and 
Down should act exactly as if the field didn't do auto-completion at all 
(because it isn't!). On Mac OS, this means go to the beginning/end of the 
field. On other OSes, it means do nothing at all.

When there are auto-completions available, the first Up/Down should open the 
auto-completion menu. The exception is on Mac OS, where the first Up/Down 
should go to the beginning/end of the field, and the second Up/Down should open 
the auto-completion menu. (This opinion is subject to slight modification when 
I finish my auto-complete spec.)

Comment 18

[Jean-Francois Ducarroz]

my mistake, the attribut doesn't exist anymore but it's up to the autocomplete
session to decide if it want the popup to show up or not, just set the
result.defaultItemIndex to 0 and the popup wont open.
The key navigation rotate the input value between results and the original input
value. Therefore you can always come back to the original input. Even when the
popup window is show it's a very convenient feature: imagine you type the
begining of a url and then the popup show up with couple of result. Now you
click on the wrong menu item! what you can do? erase part of the url and start
over! no, just use the up/down arrow to select the correct result.

Comment 19

[Jean-Francois Ducarroz]

I should have the real fix very soon...

Comment 20

[Blake Ross]

I think I have the `right' fix in hand now, I'm still just not sure about this 
behavior. I prefer what Matthew said -- just reopen the menu.

Comment 21

[Jean-Francois Ducarroz]

Attachment: Patch that fixes the navigation feature instead of disabling it

Comment 22

[Alec Flett]

cool, sr=alecf

Comment 23

[Alec Flett]

sorry, I was hasty, I'll wait for the real fix

Comment 24

[Jean-Francois Ducarroz]

Blake, what do you want to do with this bug, handing it over to me or you are
still working on it?

Comment 25

[Blake Ross]

I still think the popup should be shown first (that popup-less `feature' isn't 
too great, usability-wise), but passing off to ducarroz to finish this off.

Comment 26

[Jean-Francois Ducarroz]

reassign to hewitt. Joe, I don't know if we still need this patch with the new autocomplete widget...

Comment 27

[Joe Hewitt (gone)]

This is fixed by 43189.

Comment 28

[hangas]

Themes Triage Team Marking nsbeta1+

Comment 29

[Joe Hewitt (gone)]

fixed

Comment 30

[Claudius Gayle]

marking VERIFIED Fixed with 20010515 builds. Up arrow opens the popup...sounds like that was
what was basically decided upon so okay...