Closed
Bug 516815
Opened 15 years ago
Closed 15 years ago
Implement a way to figure out if a shell split object is inner or outer
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.9.3a1
Tracking | Status | |
---|---|---|
status1.9.2 | --- | beta1-fixed |
People
(Reporter: mrbkap, Assigned: mrbkap)
Details
(Whiteboard: fixed-in-tracemonkey)
Attachments
(1 file)
3.22 KB,
patch
|
jorendorff
:
review+
|
Details | Diff | Splinter Review |
This is uglier than I was hoping for. In the process of implementing this, I realize that we don't actually outerize in the shell anymore (oops). In order to outerize, I had to add some very ugly code that might make the shell less linkable. I'm not sure if there's a nicer solutions lying around at this point. Opinions are welcome.
Assignee | ||
Comment 1•15 years ago
|
||
Sample shell session: $ dbg-obj/js -z js> isInner true js> this.isInner false
Attachment #400882 -
Flags: review?(jorendorff)
Updated•15 years ago
|
Attachment #400882 -
Flags: review?(jorendorff) → review+
Comment 2•15 years ago
|
||
Comment on attachment 400882 [details] [diff] [review] Icky fix You call that ugly? I don't see which part would affect linkage -- maybe you meant the reference to js_ObjectOps? but we already have references to lots of friend-api stuff... Anyway, ugly is beautiful when it's in service of automated tests. r=me with gusto.
Assignee | ||
Comment 3•15 years ago
|
||
http://hg.mozilla.org/tracemonkey/rev/3f6281924c90
Whiteboard: fixed-in-tracemonkey
Target Milestone: --- → mozilla1.9.3a1
Assignee | ||
Comment 4•15 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/3f6281924c90
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Comment 5•15 years ago
|
||
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/dc320cf0725f
status1.9.2:
--- → beta1-fixed
Flags: wanted1.9.2+
You need to log in
before you can comment on or make changes to this bug.
Description
•