Closed Bug 516853 Opened 15 years ago Closed 15 years ago

TM: InitGC now takes 125ms to run on Mac

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Tracking Status
status1.9.2 --- beta1-fixed

People

(Reporter: dmandelin, Unassigned)

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 file)

Attached patch PatchSplinter Review
I discovered that this:

#ifdef __APPLE__
    memset((void *)rt->gcBase, 0, bytes);
#endif

adds about 1/8 of a second to startup time. This is particularly painful for running test suites requiring 100-3000 invocations.

Andreas said to take it out and file a new bug to do the memory touching more efficiently.
Attachment #400923 - Flags: review?(gal)
Attachment #400923 - Flags: review?(gal) → review+
The sad sob story of MacOSX page fault performance continues.
Pushed to TM as 615b519de189.
Whiteboard: fixed-in-tracemonkey
With the patch applied we only lose 9ms in the shell for SS so lets not worry too much (I don't think this affects the browser at all).
http://hg.mozilla.org/mozilla-central/rev/615b519de189
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: