Closed Bug 516898 Opened 15 years ago Closed 15 years ago

TM: Enable LIR_div/LIR_mod on x64 backend

Categories

(Core :: JavaScript Engine, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Tracking Status
status1.9.2 --- beta1-fixed

People

(Reporter: dvander, Assigned: dvander)

References

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 file)

As njn noted, trace-tests on x64 shows:

>   Trace stats check failed: got 1, expected 3 for sideExitIntoInterpreter

This is probably because we aren't doing integer speculation on division for x64 yet.
I'll shortly be posting a bug to improve the codegen for div/mod on i386;  this bug should probably wait on that one.
Depends on: 516909
Attached patch patchSplinter Review
I tried to duplicate the logic of the x86 backend as of bug 516909. Passes trace-tests, including testEliminatedGuardWithinAnchor.
Assignee: general → dvander
Status: NEW → ASSIGNED
Attachment #401145 - Flags: review?(nnethercote)
Comment on attachment 401145 [details] [diff] [review]
patch

I assume the deletion of testbug507425.js isn't meant to be in there?  r=me with that removed.

Also, a nit: I like 'mod' better than 'ins' in asm_div_mod() but it's not terribly important.
Attachment #401145 - Flags: review?(nnethercote) → review+
Thanks, not sure show that got in there. I kept 'ins' since both divs and mods can flow into that function.

http://hg.mozilla.org/tracemonkey/rev/8b7afba2b5bc
Whiteboard: fixed-in-tracemonkey
Blocks: 518488
http://hg.mozilla.org/mozilla-central/rev/8b7afba2b5bc
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: