517288 - parentID can be null or missing

Status: VERIFIED FIXED

(support.mozilla.org :: Forum, task)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

I've found a case where parentID can be missing or null, as seen here:

http://screencast.com/t/CFetQ9lw4

Wanted to get the bug filed -- I'll back-fill the steps to reproduce next.

Comment 1

[Stephen Donner [:stephend] Not actively reading bugmail]

STR:

1. Load https://support-stage.mozilla.org/tiki-view_forum.php?locale=en-US&forumId=1
2. Click "Ask a new question"
3. Choose "Problems with settings, bookmarks, passwords or other data stored by Firefox" and click "Next step"
4. Type just a space and click "Next step"
5. Type the captch, click "Next step"
6. Advance through the warnings until you see "Oops! A similar thread already exists!", and then click on "Click here to see it" (https://support-stage.mozilla.org/tiki-view_forum_thread.php?forumId=1&comments_parentId=)

Comment 2

[James Socol [:jsocol, :james]]

Attachment: patch, v1

Looks like just a missing line break.

Comment 3

[James Socol [:jsocol, :james]]

r52132 / r52133

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

I can no longer reproduce the "Oops!  A similar thread already exists!" error message (which is a necessary precondition), so I can't verify this change.

Comment 5

[James Socol [:jsocol, :james]]

I can reproduce the similar thread error, but the output doesn't seem to be consistent.

Comment 6

[James Socol [:jsocol, :james]]

Attachment: patch, v2

I'm not entirely sure why the previous patch ever worked for me? This one works for me. Of course, I'm also pretty sure the last one did before I committed it, so...

Comment 7

[Laura Thomson :laura]

Comment on attachment 402237 [details] [diff] [review]
patch, v2

It worked for me too - you are not going crazy.  Maybe we backed something out that re-broke it?  But this works.

Comment 8

[James Socol [:jsocol, :james]]

r52193 / r52194

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED; reproduced the "duplicate/similar thread exists" error, clicked through, and no longer see this error.