Closed Bug 517784 Opened 15 years ago Closed 14 years ago

--enable-xpctools breaks build

Categories

(Core :: XPConnect, defect)

Product:
Core
Component:
XPConnect
Version:
1.9.2 Branch
Platform:
All
Linux
Type:
defect
Priority:
Not set
Severity:
blocker

Tracking

()

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
status2.0 --- unaffected
status1.9.2 --- .13-fixed
status1.9.1 --- unaffected

People

(Reporter: anarchy, Assigned: anarchy)

Details

(Whiteboard: [qa-ntd-192])

Attachments

(2 files, 1 obsolete file)

updated
766 bytes, patch
timeless
: review+
christian
: approval1.9.2.13+
Details | Diff | Splinter Review
update patch for current merge
1.15 KB, patch
anarchy
: review+
Details | Diff | Splinter Review 
../../../../config/rules.mk:2268: *** Makefile variable 'REQUIRES' changed value after including rules.mk. Was 'xpcom string js caps necko dom  content editor layout rdf svg xuldoc xultmpl widget ', now xpcom string js caps necko dom  content editor layout rdf svg xuldoc xultmpl widget  xpctools..  Stop
Flags: blocking1.9.2?
Attached patch proposed fix (obsolete) — — Splinter Review 

        Attachment #401726 -
        Flags: review?(shaver)

    
    

    
  
Not blocking as this doesn't affect the release.
Flags: blocking1.9.2? → blocking1.9.2-

    
  

        Attachment #401726 -
        Flags: review?(shaver) → review?(jim)

    
  

        Attachment #401726 -
        Flags: review?(jim) → review+

    
  
Assignee: nobody → anarchy

    
  
Keywords: checkin-needed

    
    

    
  
Patch doesn't apply on mozilla-central. See http://hg.mozilla.org/mozilla-central/rev/cc3240bc917a
Keywords: checkin-needed

    
    

    
  

      
      
      
      

        Attached patch
          
          
        updated
        — 
          — Splinter Review
      

    


  

        Attachment #401726 -
        Attachment is obsolete: true

        Attachment #444378 -
        Flags: review+

    
    

    
  
http://hg.mozilla.org/venkman/rev/1c8f943af2fb
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED

    
    

    
  
oops, sorry, wrong window.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

    
  

        Attachment #444378 -
        Flags: approval1.9.2.9?

    
    

    
  
Comment on attachment 444378 [details] [diff] [review]
updated

Clearing out 1.9.2.9, requesting 1.9.2.12

        Attachment #444378 -
        Flags: approval1.9.2.9? → approval1.9.2.12?

    
  

          status2.0:
          --- → unaffected

    
  

        Attachment #444378 -
        Flags: approval1.9.2.12? → approval1.9.2.12+

    
  
Keywords: checkin-needed

    
    

    
  
This patch doesn't applies on 1.9.2 branch. Jory, could you attach an updated patch?

    
    

    
  


  
Updated patch that will apply to current state of tree.

        Attachment #482163 -
        Flags: review+

    
    

    
  
Pushed:
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/852c39d4fed7
Status: REOPENED → RESOLVED
Closed: 14 years ago → 14 years ago

          status1.9.2:
          --- → .12-fixed
Resolution: --- → FIXED

    
    

    
  
Nothing for QA to do here for 1.9.2.
Whiteboard: [qa-ntd-192]

    
  

          status1.9.1:
          --- → unaffected

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: