518014 - preference about fennec button doesn't show webpage

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

on my n810 i go to preferences and click on the go to page button for about fennec.  this appears to do nothing, but if i manually switch back to the browser, i will see a new tab with about:fennec loaded up.

please make the button switch back to the browser window.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

We seem to be in flux over whether BrowserUI.newTab should make sure the browser tools panel is closed or not while adding a new tab. Since we now have 3 callers that want this behavior I am putting it back in BrowserUI.newTab()

The call to BrowserUI.hidePanel() is safe for other callers. Maybe I should put a comment in BrowserUI.newTab() so people don't remove the call again.

Comment 2

[Aakash Desai [:aakashd]]

I'm confirming this on builds:

Mozilla/5.0 (Windows; U; WindowsCE 5.2; en-US; rv:1.9.2a2pre) Gecko/20090922 Fennec/1.0a3

and

Mozilla/5.0 (X11; U; Linux armv6l; en-US; rv:1.9.2a2pre) Gecko/20090922
Fennec/1.0b4pre

...and i'm adding the blocking-fennec? flag as well as upping the severity.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
https://hg.mozilla.org/mobile-browser/rev/21eff921ef4b

Comment 4

[Aakash Desai [:aakashd]]

verified FIXED On builds:

Mozilla/5.0 (Windows; U; WindowsCE 5.2; en-US; rv:1.9.2b1pre) Gecko/20090923 Fennec/1.0a3

and

Mozilla/5.0 (X11; U; Linux armv6l; en-US; rv:1.9.2b1pre) Gecko/20090923
Fennec/1.0b4pre

and

Mozilla/5.0 (X11; U; Linux armv7l; en-US; rv:1.9.2b1pre) Gecko/20090923
Fennec/1.0b4pre