Closed Bug 518026 Opened 15 years ago Closed 15 years ago

TM: trace-test.py: option to run any test case under valgrind

Categories

(Core :: JavaScript Engine, enhancement)

Product:
Core
Component:
JavaScript Engine
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
status1.9.2 --- beta1-fixed

People

(Reporter: dmandelin, Assigned: dmandelin)

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 file)

Patch
3.07 KB, patch
graydon
: review+
Details | Diff | Splinter Review
Attached patch Patch — — Splinter Review 
This builds on bug 512591 by allowing any test(s) to be run with valgrind. It adds an option --valgrind-all that runs all tests under valgrind. This option also enables --show-output because otherwise it's kind of pointless. :-)
Attachment #401988 - Flags: review?(graydon)
Attachment #401988 - Attachment is patch: true
Attachment #401988 - Attachment mime type: application/octet-stream → text/plain
Actually the patch I committed had a small-n-subtle change to redirect *stderr* only when the test.valgrind condition is set. This is what you want rather than blunt enabling of --show-output; we have some tests that --show-output will cause to spew hundreds of pages of trace chatter (those that test logging).

If you remove that hunk though, this patch looks fine.
Comment on attachment 401988 [details] [diff] [review]
Patch

all but the last hunk
Attachment #401988 - Flags: review?(graydon) → review+
Missed that. Pushed to TM with fix as 886a447d6a8f.
Whiteboard: fixed-in-tracemonkey
http://hg.mozilla.org/mozilla-central/rev/886a447d6a8f
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Flags: in-testsuite-
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: