518175 - Stop stripping mac nightlies

Status: RESOLVED FIXED

(Thunderbird :: Build Config, defect, P2)

Description

[Philippe M. Chiasson (:gozer)]

+++ This bug was initially created as a clone of Bug #515645 +++

We should --disable-install-strip our mac nightlies.  That will let us shark them, make the apple crash reporter work (in cases when breakpad doesn't trigger for some reason), and generally make them happier campers.

The claim is that the download size increase here is negligible, which I buy.

Comment 1

[Mark Banner (:standard8)]

Attachment: [checked in] The fix

Ok, this sounds a reasonable thing to do. If I understand correctly the major benefits for us are:

1) Using the apple profiler should give us correct symbols for nightly builds. This would be helpful in the case of hangs.
2) If crash reporter failed, then the apple crash reporter would pick up the right symbols.

The downside is a larger nightly build. Looking at Firefox's changes here's some important additional notes:

- Firefox has not done this for release builds (this patch should also not do it for release builds, but I'd like gozer to verify that).

- There was an approx 6Mb increase in the size of Mac nightlies on Firefox when stripping was disabled. The partial mar was 8Mb that day.

- Subsequent partial mars for the next few days were typically a 200 to 300 kb.

Although the build size is generally seen as something to be kept small, I think we should take this hit as I've seen various situations recently (especially with our hangs on shutdown) where it would be useful for nightly users to have this symbol information.

Comment 2

[Philippe M. Chiasson (:gozer)]

Comment on attachment 403205 [details] [diff] [review]
[checked in] The fix

And Standard8 is correct, this will not affect release builds.

Comment 3

[Dan Mosedale (:dmosedale, :dmose)]

A 6mb increase from what to what?

Will making this change to the nightlies also mean that actual releases will get it also?

Comment 4

[Dan Mosedale (:dmosedale, :dmose)]

To be clear, I'm asking about dmg size differences, not mar size differences.

Comment 5

[Mark Banner (:standard8)]

(In reply to comment #3)
> A 6mb increase from what to what?

The .dmg size. From before the change (which was stripping symbols) to after the change (not stripping symbols).

> Will making this change to the nightlies also mean that actual releases will
> get it also?

No. See my comment and gozer's comments.

Comment 6

[Dan Mosedale (:dmosedale, :dmose)]

(In reply to comment #5)
> (In reply to comment #3)
> > A 6mb increase from what to what?
> 
> The .dmg size. From before the change (which was stripping symbols) to after
> the change (not stripping symbols).

Right, but what was the size and the size after?

Comment 7

[Dan Mosedale (:dmosedale, :dmose)]

Er size before and size after.  

/me swigs some more coffee.

Comment 8

[Mark Banner (:standard8)]

For Firefox (from 1.9.1): 17405 KB -> 23668 KB

Thunderbird's current nightly size is 19081 KB

Comment 9

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 403205 [details] [diff] [review]
[checked in] The fix

sr=dmose

Comment 10

[Philippe M. Chiasson (:gozer)]

Comment on attachment 403205 [details] [diff] [review]
[checked in] The fix

comparing with ssh://hg.mozilla.org/build/buildbot-configs
searching for changes
changeset:   1553:90d473dda32b
tag:         tip
user:        Philippe M. Chiasson <[e-mail]>
date:        Mon Sep 28 15:16:58 2009 -0400
summary:     Bug 518175 - Stop stripping mac nightlies. r=gozer, sr=dmose

Comment 11

[Philippe M. Chiasson (:gozer)]

Buildbot mater reconfig-ed. Tonight's nightlies should run with this mozconfig