Closed
Bug 518219
Opened 15 years ago
Closed 15 years ago
Socorro UI - top crash by url should use dashboard config
Categories
(Socorro :: General, task)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: lars, Unassigned)
Details
Attachments
(2 files)
6.29 KB,
patch
|
ozten
:
review-
|
Details | Diff | Splinter Review |
2.28 KB,
patch
|
ozten
:
review+
|
Details | Diff | Splinter Review |
It seems that the top crash by url widget on the front page doesn't use the dashboard config to get its list of products and versions to display. The attachment is a patch (based on Austin's patch on Bug 51800) that corrects this problem.
Attachment #402188 -
Flags: review?(ozten.bugs)
Reporter | ||
Comment 1•15 years ago
|
||
oh yeah, my editor also replaced all the <tab> characters in the file with spaces, so the patch reflects that. The indentation is now much more uniform.
Updated•15 years ago
|
Attachment #402188 -
Flags: review?(ozten.bugs) → review-
Comment 2•15 years ago
|
||
Comment on attachment 402188 [details] [diff] [review] patch to .../webapp-php/applications/controllers/home.php to make the top crash widget use the dashboad config Almost there... Line 121 duplicates 127 Line 125, 126 delete. (We don't need $all_reports or $prodToVersionMap) Line 140 - delete $other-versions - this variable was there for consistency, but I don't believe it's used by the TCBYURL widget and it's the only remaining reference from $all_reports, so it's worth breaking consistency to remove this dependency. Please wait until a normal dev cycle to reformat a file's whitespace... We're trying to resolve a production issue, let's introduce as few changes as possible.
Reporter | ||
Comment 3•15 years ago
|
||
this is the second stab a the patch it was amazing how long it took to get my Python IDE to not muck around with the indentation levels...
Attachment #402380 -
Flags: review?(ozten.bugs)
Comment 4•15 years ago
|
||
Comment on attachment 402380 [details] [diff] [review] return of the php patch - now with additional code removed and whitespace untouched Great patch. Tested, looks good. Thanks for making this change on top crashes by url widget.
Attachment #402380 -
Flags: review?(ozten.bugs) → review+
Reporter | ||
Updated•15 years ago
|
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•13 years ago
|
Component: Socorro → General
Product: Webtools → Socorro
You need to log in
before you can comment on or make changes to this bug.
Description
•