518363 - download manager: retry button always visible

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Madhava Enros [:madhava]]

See here:  http://www.flickr.com/photos/42739110@N07/3948019548/in/photostream/


In that screenshot, the first row is selected, which is why the row's buttons are revealed.  The second and third row are not selected, so the buttons should be hidden and the row collapsed to its normal height.  The "Retry" button is always visible.

Comment 1

[Aakash Desai [:aakashd]]

Agreed, I'm seeing this on builds:

Mozilla/5.0 (Windows; U; WindowsCE 5.2; en-US; rv:1.9.2b1pre) Gecko/20090925 Fennec/1.0a3

and

Mozilla/5.0 (X11; U; Linux armv6l; en-US; rv:1.9.2b1pre) Gecko/20090925
Fennec/1.0b4pre

and

Mozilla/5.0 (X11; U; Linux armv7l; en-US; rv:1.9.2b1pre) Gecko/20090925
Fennec/1.0b4pre

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch

This hides the button unless the item is selected as requested, but this raises a different question - the downloads in question have failed or have been canceled, and there's no good indication that that's the case (the button wasn't ideal, but it was _something_, at least).

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 404553 [details] [diff] [review]
patch

I like this and I have a patch that builds on this.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch 2 (adds a 'failed' label)

This patch builds on the first and adds a "Failed" label to the row when it is not selected.

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: the diff

this is the diff between the two patches

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
https://hg.mozilla.org/mobile-browser/rev/63d20eed1e3b

Comment 7

[Aakash Desai [:aakashd]]

verified FIXED on builds:

Mozilla/5.0 (X11; U; Linux armv6l; en-US; rv:1.9.2b1pre) Gecko/20091007
Fennec/1.0b4

and

Mozilla/5.0 (X11; U; Linux armv7l; en-US; rv:1.9.2b1pre) Gecko/20091007
Fennec/1.0b4