Closed
Bug 518724
Opened 15 years ago
Closed 15 years ago
NJ merge: yet more Assembler/Nativei386.cpp folderol
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| status1.9.2 | --- | beta1-fixed |
People
(Reporter: n.nethercote, Assigned: n.nethercote)
References
Details
(Whiteboard: fixed-in-tracemonkey)
Attachments
(1 file)
|
12.81 KB,
patch
|
graydon
:
review+
|
Details | Diff | Splinter Review |
This patch absorbs useful stuff from Tamarin: - Zeroes some additional fields in class Assembler's constructor, which seems harmless. - Replaces a test with an assertion to resourceConsistencyCheck(); this is valid because error() is checked before resourceConsistencyCheck() is called. - Uses RegisterMask instead of uint32_t in a place. - Adds some PPC-specific code to findRegFor(). - Removes countlir_loop(), which is dead, and updates a related comment. - Adds an assertion to arFree(). - Replaces our printActivationState() wholesale with TR's, because it's much better. And adds a couple of calls to it guarded by TMFLAGS=activation. And enables TMFLAGS=activation in TM... goodness, that's quite a useful debug flag.
Attachment #402712 -
Flags: review?(graydon)
|
||
Updated•15 years ago
|
Attachment #402712 -
Flags: review?(graydon) → review+
|
Assignee | |
Comment 1•15 years ago
|
||
http://hg.mozilla.org/tracemonkey/rev/e297bdbaf384
Whiteboard: fixed-in-tracemonkey
|
||
Comment 2•15 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/e297bdbaf384
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
|
|
||
Comment 3•15 years ago
|
||
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/8fe1e4ceddd1
status1.9.2:
--- → beta1-fixed
Flags: wanted1.9.2+
You need to log in
before you can comment on or make changes to this bug.
Description
•