Closed
Bug 518731
Opened 15 years ago
Closed 15 years ago
JSSLOT_ARRAY_COUNT is incorrect in array returned from Object.keys
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
People
(Reporter: Waldo, Assigned: Waldo)
References
()
Details
(Whiteboard: fixed-in-tracemonkey)
Attachments
(1 file)
|
905 bytes,
patch
|
mrbkap
:
review+
|
Details | Diff | Splinter Review |
This should only matter for denseness considerations. I think. However, I'm not absolutely confident we always do that (it being a whole-system consideration), so to be safe we should do this even if we're not worried about Object.keys(O) arrays and their denseness over time. I really wish we had some better way to track sparseness than tracking this count everywhere in such a fragile manner, also slowing down dense-array sets when we eventually make tracing those sets not involve function-call overhead, but I don't see anything obvious to do instead. :-(
Attachment #402726 -
Flags: review?(mrbkap)
|
||
Updated•15 years ago
|
Attachment #402726 -
Flags: review?(mrbkap) → review+
|
Assignee | |
Comment 1•15 years ago
|
||
http://hg.mozilla.org/tracemonkey/rev/4a35dd652448
Whiteboard: fixed-in-tracemonkey
|
||
Comment 2•15 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/4a35dd652448
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•