518888 - Ask a question form's final, required fields are out of the viewport's view

Status: VERIFIED FIXED

(support.mozilla.org :: Forum, task, P2)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Screenshot

STR:

1. Reduce your viewport to be about half the height of a typical 1024x768 (etc.) screen, so around 580 pixels
2. Load http://support-stage.mozilla.org/en-US/kb/Support+Website+Forums
3. Click on "Ask a new question"
4. Advance through the screens until "Ask a question step 4 of 4"
5. Type something in the "Fill in the details of your question" text box and click "Submit your question"

Even though there is a scrollbar, it's not clear there's a lot of other required fields.

Comment 1

[[:Cww]]

1) Lots of netbooks have only 600 px vertical height so it's not an uncommon usecase.

2) The issue is that the submit button is still there and active so it looks like you're seeing the entirety of the form when you're not.  The previous screens of the dialog scroll inside the browser (and people with short screens expect to have to scroll) but this one has its own scrollbar which is confusing.

Comment 2

[Paul Craciunoiu [:paulc]]

So you're saying let's just let the modal window expand height instead of making it fit inside but adding a scrollbar inside it?

Comment 3

[James Socol [:jsocol, :james]]

(In reply to comment #2)
> So you're saying let's just let the modal window expand height instead of
> making it fit inside but adding a scrollbar inside it?

+1. That's what I'd recommend.

Comment 4

[Paul Craciunoiu [:paulc]]

1.4.1 ok?

Comment 5

[[:Cww]]

Yeah, 1.4.1 is going to be epic.

Comment 6

[David Tenser [:djst]]

Affects roughly 2.9% of our visitors (based on total page hits, not traffic to the forum).

Not sure if related, but I also noticed that the box appears too far to the left if screen size is narrow, e.g. 640x480 -- the box is then not centered on the screen. Not a big deal though (affects roughly 0.2% of visitors).

Comment 7

[Paul Craciunoiu [:paulc]]

Attachment: v1

No "max-height" does the trick.

Comment 9

[Paul Craciunoiu [:paulc]]

r52769 (trunk only)

Comment 10

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Post-fix screenshot on Ubuntu 9.04

Cheng, does this look good to you?  Can you confirm with your setup too?  Thanks!

Comment 11

[[:Cww]]

It looks good as far as addressing the bug but for some reason when you click next from step 3, it takes you to the middle of the form rather being scrolled up to the top.  That's not a big deal, just weird.

Comment 12

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #11)
> It looks good as far as addressing the bug but for some reason when you click
> next from step 3, it takes you to the middle of the form rather being scrolled
> up to the top.  That's not a big deal, just weird.

thx, Cheng -- sounds like a spinoff candidate.

Verified FIXED

Comment 13

[Paul Craciunoiu [:paulc]]

r53560 (prod)